Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add deep_poverty_rate and squared_poverty_gap #95

Closed
wants to merge 3 commits into from
Closed

Add deep_poverty_rate and squared_poverty_gap #95

wants to merge 3 commits into from

Conversation

MaxGhenis
Copy link
Collaborator

As household attributes and aggregates. Fixes #71 and fixes #94. No tests yet.

@MaxGhenis MaxGhenis requested a review from nikhilwoodruff March 4, 2021 09:07
@MaxGhenis
Copy link
Collaborator Author

Note the squares are off by a factor of 52 due to #92:

t = sim.df(["poverty_gap_bhc", "squared_poverty_gap_bhc"])
t[t.poverty_gap_bhc > 0]

poverty_gap_bhc | squared_poverty_gap_bhc
-- | --
2678.419434 | 1.379604e+05
8283.265625 | 1.319472e+06
8283.265625 | 1.319472e+06
8283.265625 | 1.319472e+06
1114.882568 | 2.390311e+04

Is there a way to use poverty_gap directly in the squared_poverty_gap function?

@MaxGhenis MaxGhenis marked this pull request as draft March 15, 2021 17:19
@MaxGhenis MaxGhenis marked this pull request as ready for review April 28, 2021 18:03
@MaxGhenis MaxGhenis mentioned this pull request Apr 28, 2021
Merged
@MaxGhenis
Copy link
Collaborator Author

Closing as this is inconsistent with the new structure. Added deep poverty in #115 and squared poverty gaps can be dealt with elsewhere or with simple microdf commands.

@MaxGhenis MaxGhenis closed this Apr 28, 2021
@nikhilwoodruff nikhilwoodruff mentioned this pull request Jun 1, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikhilwoodruff nikhilwoodruff nikhilwoodruff approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add squared poverty gap Add deep poverty
2 participants
@MaxGhenis @nikhilwoodruff