Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect brush rotation logic leading to random ghost window borders while dragging #31

Open
PluMGMK opened this issue Jan 19, 2025 · 0 comments

Comments

@PluMGMK
Copy link
Owner

PluMGMK commented Jan 19, 2025

As mentioned by Michal Necasek here, the V7VGA driver (from which this one is derived) has a bug in its non-accelerated brush-rotation code, which causes "droppings" of the selection rectangle when dragging windows. The brush-rotation code in VBESVGA.DRV was refactored and rewritten to support multi-byte pixels, but evidently I preserved the logic bug during the rewrite, because I have noticed these "droppings" too. I need to go back through the code, understand how it works, and fix it properly…

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant