Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RLE bitmaps are not decoded properly #11

Open
PluMGMK opened this issue Dec 17, 2024 · 2 comments
Open

RLE bitmaps are not decoded properly #11

PluMGMK opened this issue Dec 17, 2024 · 2 comments

Comments

@PluMGMK
Copy link
Owner

PluMGMK commented Dec 17, 2024

Same game I referred to on my website a few years ago… The toolbar has some buttons which I believe use monochrome bitmaps to indicate their functions. However, when playing using this driver, the buttons render with random colour bitmaps instead. Presumably a mono/colour check is broken somewhere in the driver…

@PluMGMK
Copy link
Owner Author

PluMGMK commented Dec 18, 2024

This screenshot taken on v0.1.1 illustrates the issue:
MiniGolf screenshot showing garbage in toolbar buttons
The option buttons to the right also demonstrate #12, and the artefacts to the left of the flag icon, and of the minimize button in the titlebar, demonstrate #5.

For reference, here's how it looks with the standard VGA driver:
MiniGolf screenshot showing correct rendering using standard VGA driver

@PluMGMK PluMGMK changed the title Toolbar icons in MiniGolf display random garbage RLE bitmaps are not decoded properly Dec 25, 2024
@PluMGMK
Copy link
Owner Author

PluMGMK commented Dec 25, 2024

Looks like these icons are 4-bit RLE bitmaps, and I haven't touched the RLE code in this driver since starting from the V7VGA baseline, so this probably explains the garbage – renaming issue accordingly…

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant