diff --git a/src/main/java/org/owasp/webgoat/lessons/challenges/challenge5/Assignment5.java b/src/main/java/org/owasp/webgoat/lessons/challenges/challenge5/Assignment5.java index d6b8dccebb..7941ffeb9e 100644 --- a/src/main/java/org/owasp/webgoat/lessons/challenges/challenge5/Assignment5.java +++ b/src/main/java/org/owasp/webgoat/lessons/challenges/challenge5/Assignment5.java @@ -58,11 +58,9 @@ public AttackResult login( try (var connection = dataSource.getConnection()) { PreparedStatement statement = connection.prepareStatement( - "select password from challenge_users where userid = '" - + username_login - + "' and password = '" - + password_login - + "'"); + "select password from challenge_users where userid = ? and password = ?"); + statement.setString(1, username_login); + statement.setString(2, password_login); ResultSet resultSet = statement.executeQuery(); if (resultSet.next()) { @@ -71,5 +69,4 @@ public AttackResult login( return failed(this).feedback("challenge.close").build(); } } - } }