Remove unnecessary null pointer checks

[elfring]

An extra null pointer check is not needed in functions like the following.

• GlfUVTextureStorageData
• HdMeshTopology::SetQuadInfo

[amooty]

Filed as internal issue #135159.

[superfunc]

Note this code has been cleaned up since and can be closed: https://github.com/PixarAnimationStudios/USD/blob/022f7ef54ff8ce15120f34e61e078c1daf471153/pxr/imaging/lib/hdSt/meshTopology.cpp#L83-87

[elfring]

There are further update candidates to consider, aren't there?

[superfunc]

Looks like I was wrong; I hadn't realized this was pointing to a more general problem and not those specific callouts, my apologies.

[elfring]

I am just curious if all possible improvements were integrated into this software for the reported search pattern.

[elfring]

Would you like to take another look also at any included software libraries?

[elfring]

How will the software evolution be continued around a class like “GlfUVTextureStorageData”?

[elfring]

How do you think about to use a development tool like “clang-tidy” for corresponding source code adjustments?

[Cewein]

This issue is quite old, is it still relevent ? I am willing to do a thorough check if needed.

[meshula]

Bug reports with repro's, and PRs with code quality or quality of life improvements are always welcome of course.

I don't think it's useful to keep a general issue open for years as a substitute for an ongoing review process though. OpenUSD is subject to extensive testing, as well as continuous development, so I'd suggest that if you do undertake a check, please open PRs with suggested improvements, or issues with bug reports if it's not clear how to proceed.

[meshula]

I'm closing it out, per my explanation above.

[elfring]

🔮 Would you like to share any more information also according to an internal issue like #135159?

[meshula]

135159 is our internal tracking number for this github issue. There is no extra information there.

The pattern of checking the glProgram does not impact correctness or performance so it will probably not get attention in a reasonable amount of time. Since you are still interested in this issue would mind perhaps working with @Cewein to create a PR for us to look at, since he has offered to help?