Autodesk: usdImagingGL: support for Hgi specific variants of tests #3479
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change(s)
Support Hgi specific variants of tests to work around missing Hgi features without needing to entirely disable tests. More specifically in this PR, use separate Metal baselines for tests that have wide line primitives, since Metal only supports one pixel wide lines.
Mechanism:
The placeholder string
@hgi_suffix@
is replaced by anHgi
suffix when necessary.For all listed
Hgi
variants supported, register a suffixed test with a suffixed baseline.testUsdImagingGLExample_Metal
=>testUsdImagingGLExample_Metal_1.1.png
testUsdImagingGLExample_WebGPU
=>testUsdImagingGLExample_WebGPU_1.1.png
Other supported
Hgi
s are also register with a suffix, but use a non-suffixed baseline:testUsdImagingGLExample_GL
=>testUsdImagingGLExample_1.1.png
testUsdImagingGLExample_Vulkan
=>testUsdImagingGLExample_1.1.png
Unsupported
Hgi
s are ignored:testUsdImagingGLExample_GL
would not be registered on Apple platformsIf none of the
Hgi
variants are supported, then register a single test like normal:testUsdImagingGLExample
=>testUsdImagingGLExample_1.1.png
The proper
Hgi
enable settings are appended to theENV
argument for all suffixed tests:_Metal
:HGI_ENABLE_VULKAN=0;HGI_ENABLE_WEBGPU=0
_GL
:HGI_ENABLE_VULKAN=0;HGI_ENABLE_WEBGPU=0
_Vulkan
:HGI_ENABLE_VULKAN=1
_WebGPU
:HGI_ENABLE_WEBGPU=1
Link to proposal (if applicable)
Fixes Issue(s)
Checklist
I have created this PR based on the dev branch
I have followed the coding conventions
I have added unit tests that exercise this functionality (Reference:
testing guidelines)
I have verified that all unit tests pass with the proposed changes
I have submitted a signed Contributor License Agreement (Reference:
Contributor License Agreement instructions)