usdShade: Add ShaderValidator #3398
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added equivalent validation checks from ARShaderChecker in the new ValidationFramework, including validation implementation code, test code, tokens, and an entry in plugInfo.json
beersandrew
commented
Nov 4, 2024
| shaderInput.GetAttr().GetPath().GetText(), | ||
| sources.size()) | ||
| ); | ||
| continue; |
There was a problem hiding this comment.
@tallytalwar one note here, I noticed this was not present in the other validator here however:
- We do get a warning below when calling
GetConnectedSourcesince with multiple sources we should callGetConnectedSources - It appears
GetConnectedSourcegets the first connected source, so the complianceChecker code would not be validating issues for other connected sources
Happy to change this and loop through the connected sources if you think it's better to add that logic in, it made sense to me to stop checking since no matter what the connections were, it seems invalid to have more than one. Let me know if that's incorrect.
|
Filed as internal issue #USD-10396 |
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Closing this PR, this work is now done on #3447 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change(s)
Link to proposal (if applicable)
Fixes Issue(s)
Checklist
[X] I have created this PR based on the dev branch
[X] I have followed the coding conventions
[X] I have added unit tests that exercise this functionality (Reference:
testing guidelines)
[X] I have verified that all unit tests pass with the proposed changes
[X] I have submitted a signed Contributor License Agreement (Reference:
Contributor License Agreement instructions)