Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

better calibration data model #469

Open
2 of 7 tasks
CamDavidsonPilon opened this issue Feb 6, 2024 · 3 comments
Open
2 of 7 tasks

better calibration data model #469

CamDavidsonPilon opened this issue Feb 6, 2024 · 3 comments

Comments

@CamDavidsonPilon
Copy link
Member

CamDavidsonPilon commented Feb 6, 2024

  • It would be nice if all calibrations looked the same, without having to update each one and make sure the syntax is correct. Maybe this would help? https://click.palletsprojects.com/en/8.1.x/commands/#custom-multi-commands
  • Users want to share calibrations, edit them, etc. It would be a great idea for calibrations to be flat files on disk (yaml?), instead of stored in a db.
  • A UI page that (in the general section):
    • has a list of each workers calibrations
    • a way to view calibrations (a chart?)
    • a way to select calibrations to use
    • a way to run calibrations (stirring, pump, OD, LED (via a plugin??))
@CamDavidsonPilon CamDavidsonPilon changed the title better calibration model better calibration data model Feb 6, 2024
@CamDavidsonPilon
Copy link
Member Author

CamDavidsonPilon commented Dec 13, 2024

  • Calibrations will be yaml files stored locally in .pioreactor/storage/calibrations/<type>

@CamDavidsonPilon
Copy link
Member Author

Hm, I need to separate the type of calibration, from what is being calibrated. The latter determines the folder structure (this enables moving a calibration from the media_pump folder to the waste_pump folder for example).

@CamDavidsonPilon
Copy link
Member Author

Next: I need an two APIs for different calibration protocols:

  1. How does the user choose (discover??) a specific protocol to calibrate device D?
  2. How does a 3p developer add a protocol, calibration type, etc. to target device D?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant