Fix imported account refresh authority and reused-token recovery - #6
Conversation
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a8a90480ad
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
1 similar comment
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d59c9eada2
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
22bdda2 to
94c0fe9
Compare
Pimpmuckl
changed the title
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 94c0fe965f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Make imported account profiles the sole rotating refresh-token authority, serialize cross-process auth transitions, retire terminal credentials safely, and resolve structural account markers before workspace enforcement.
94c0fe9 to
ddca46e
Compare
Resolve reused rotating refresh tokens across imported accounts, serialize auth transitions, retire terminal credentials safely, and enforce workspace policy against resolved account authorities.
Resolve reused rotating refresh tokens across imported accounts, serialize auth transitions, retire terminal credentials safely, and enforce workspace policy against resolved account authorities.
1 participant
Why
Codex++ could retain the same rotating ChatGPT refresh token in both root auth storage and an imported account profile. Concurrent managers or processes could spend that one-time token twice, producing
refresh_token_reused; stale imported accounts then remained selectable, so the error could recur on startup or when opening a thread.What changed
Validation
just test -p codex-login: 187 passedjust test -p codex-cli login: 6 passedjust test -p codex-tui account_usage: 4 passedjust fix -p codex-login -p codex-tuicodex-cli 0.144.1-forkThe reused-token regression reproduced the original user-facing failure before the fix and passes with the final implementation.