Skip to content

feat(hooks): support ask reviews for PreToolUse - #30

Merged
Pimpmuckl merged 1 commit into
mainfrom
feature/pretooluse-ask-all-tools
Jul 12, 2026
Merged

feat(hooks): support ask reviews for PreToolUse#30
Pimpmuckl merged 1 commit into
mainfrom
feature/pretooluse-ask-all-tools

Conversation

@Pimpmuckl

@Pimpmuckl Pimpmuckl commented Jul 12, 2026 •
edited
Loading

Copy link
Copy Markdown
Owner

Summary

  • support permissionDecision: "ask" for PreToolUse hooks across generic function, shell/exec, apply-patch, and MCP tool dispatch
  • route hook-requested reviews through Guardian even under danger-full-access / never-ask mode, preserving deny > ask > continue precedence and fail-closed errors
  • expose typed PreToolUse Guardian lifecycle and analytics actions, with bounded Guardian prompt context and regenerated app-server schemas
  • keep fork-owned Guardian review policy isolated in core/src/tools/codex_plus_plus/pre_tool_use_review.rs

Validation

  • just test -p codex-hooks: 121 passed; 2 existing Windows hook-fixture launch failures
  • just test -p codex-core: production code compiled; 2555 passed, with existing Windows binary/fixture prerequisites causing 43 failures and 2 unrelated timeouts
  • just test -p codex-analytics: 84 passed
  • focused Guardian aggregate action cap: passed
  • focused target-item correlation test: passed
  • focused TUI Guardian snapshot: passed and accepted
  • just write-app-server-schema
  • scoped just fix for codex-hooks, codex-core, codex-analytics, codex-app-server-protocol, and codex-tui
  • just fmt

Review and CI status

  • Review Suite normal rvw_c2c6fe90: complete and clean
  • anchored GitHub review: clean on 170b58d39e2aa8e0f0feb5094c4943f9d517bd78
  • GitHub Actions are disabled at repository level; the final head reports no checks

@Pimpmuckl

Pimpmuckl commented Jul 12, 2026

Copy link
Copy Markdown
Owner Author

@codex review

chatgpt-codex-connector[bot]
chatgpt-codex-connector Bot reviewed Jul 12, 2026
View reviewed changes

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 6c364804be

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread codex-rs/core/src/guardian/approval_request.rs Outdated
@Pimpmuckl
Pimpmuckl force-pushed the feature/pretooluse-ask-all-tools branch 4 times, most recently from 2cf149c to f3561c1 Compare July 12, 2026 12:15
@Pimpmuckl

Pimpmuckl commented Jul 12, 2026

Copy link
Copy Markdown
Owner Author

@codex review

chatgpt-codex-connector[bot]
chatgpt-codex-connector Bot reviewed Jul 12, 2026
View reviewed changes

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: f3561c1fe1

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread codex-rs/hooks/src/engine/output_parser.rs
@Pimpmuckl
Pimpmuckl force-pushed the feature/pretooluse-ask-all-tools branch 2 times, most recently from 56d72ed to 9cc15fb Compare July 12, 2026 12:33
@Pimpmuckl

Pimpmuckl commented Jul 12, 2026

Copy link
Copy Markdown
Owner Author

@codex review

chatgpt-codex-connector[bot]
chatgpt-codex-connector Bot reviewed Jul 12, 2026
View reviewed changes

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 9cc15fb02c

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread codex-rs/core/src/guardian/approval_request.rs
@Pimpmuckl
Pimpmuckl force-pushed the feature/pretooluse-ask-all-tools branch from 9cc15fb to eb2943e Compare July 12, 2026 12:44
@Pimpmuckl

Pimpmuckl commented Jul 12, 2026

Copy link
Copy Markdown
Owner Author

@codex review

chatgpt-codex-connector[bot]
chatgpt-codex-connector Bot reviewed Jul 12, 2026
View reviewed changes

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: eb2943e9e1

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread codex-rs/core/src/guardian/approval_request.rs
Comment thread codex-rs/core/src/tools/registry.rs Outdated
@Pimpmuckl
Pimpmuckl force-pushed the feature/pretooluse-ask-all-tools branch 3 times, most recently from d0a96df to aafc95d Compare July 12, 2026 13:13
@Pimpmuckl

Pimpmuckl commented Jul 12, 2026

Copy link
Copy Markdown
Owner Author

@codex review

chatgpt-codex-connector[bot]
chatgpt-codex-connector Bot reviewed Jul 12, 2026
View reviewed changes

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: aafc95d5db

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread codex-rs/core/src/tools/registry.rs Outdated
Comment thread codex-rs/hooks/src/events/pre_tool_use.rs Outdated
@Pimpmuckl
Pimpmuckl force-pushed the feature/pretooluse-ask-all-tools branch 4 times, most recently from 90ba8d9 to 7a58c98 Compare July 12, 2026 13:41
@Pimpmuckl

Pimpmuckl commented Jul 12, 2026

Copy link
Copy Markdown
Owner Author

@codex review

chatgpt-codex-connector[bot]
chatgpt-codex-connector Bot reviewed Jul 12, 2026
View reviewed changes

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 7a58c984a6

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread codex-rs/core/src/guardian/approval_request.rs
@Pimpmuckl
Pimpmuckl force-pushed the feature/pretooluse-ask-all-tools branch from 7a58c98 to f2e90f6 Compare July 12, 2026 13:56
@Pimpmuckl

Pimpmuckl commented Jul 12, 2026

Copy link
Copy Markdown
Owner Author

@codex review

chatgpt-codex-connector[bot]
chatgpt-codex-connector Bot reviewed Jul 12, 2026
View reviewed changes

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: f2e90f69f4

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread codex-rs/core/src/tools/registry.rs Outdated
@Pimpmuckl
Pimpmuckl force-pushed the feature/pretooluse-ask-all-tools branch from f2e90f6 to ddb9f8f Compare July 12, 2026 14:14
@Pimpmuckl

Pimpmuckl commented Jul 12, 2026

Copy link
Copy Markdown
Owner Author

@codex review

chatgpt-codex-connector[bot]
chatgpt-codex-connector Bot reviewed Jul 12, 2026
View reviewed changes

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: ddb9f8f911

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread codex-rs/core/src/guardian/approval_request.rs Outdated
@Pimpmuckl
Pimpmuckl force-pushed the feature/pretooluse-ask-all-tools branch from ddb9f8f to 1e78b95 Compare July 12, 2026 14:48
@Pimpmuckl

Pimpmuckl commented Jul 12, 2026

Copy link
Copy Markdown
Owner Author

@codex review

chatgpt-codex-connector[bot]
chatgpt-codex-connector Bot reviewed Jul 12, 2026
View reviewed changes

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 1e78b95011

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread codex-rs/core/src/guardian/approval_request.rs Outdated
@Pimpmuckl
Pimpmuckl force-pushed the feature/pretooluse-ask-all-tools branch from 1e78b95 to 9b72b8b Compare July 12, 2026 15:01
@Pimpmuckl

Pimpmuckl commented Jul 12, 2026

Copy link
Copy Markdown
Owner Author

@codex review

chatgpt-codex-connector[bot]
chatgpt-codex-connector Bot reviewed Jul 12, 2026
View reviewed changes

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 9b72b8bd4e

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread codex-rs/core/src/tools/registry.rs Outdated
Comment thread codex-rs/hooks/src/events/pre_tool_use.rs
Comment thread codex-rs/app-server-protocol/src/protocol/v2/item.rs
@Pimpmuckl
Pimpmuckl force-pushed the feature/pretooluse-ask-all-tools branch from 9b72b8b to 772fa36 Compare July 12, 2026 15:19
@Pimpmuckl

Pimpmuckl commented Jul 12, 2026

Copy link
Copy Markdown
Owner Author

@codex review

1 similar comment
@Pimpmuckl

Pimpmuckl commented Jul 12, 2026

Copy link
Copy Markdown
Owner Author

@codex review

chatgpt-codex-connector[bot]
chatgpt-codex-connector Bot reviewed Jul 12, 2026
View reviewed changes

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 772fa3619f

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread codex-rs/analytics/src/reducer.rs Outdated
@Pimpmuckl
Pimpmuckl force-pushed the feature/pretooluse-ask-all-tools branch from 772fa36 to 170b58d Compare July 12, 2026 15:36
@Pimpmuckl

Pimpmuckl commented Jul 12, 2026

Copy link
Copy Markdown
Owner Author

@codex review

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Jul 12, 2026

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. 🎉

Reviewed commit: 170b58d39e

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@Pimpmuckl
Pimpmuckl merged commit 6d5a197 into main Jul 12, 2026
Pimpmuckl added a commit that referenced this pull request Jul 13, 2026
@Pimpmuckl
Merge pull request #30 from Pimpmuckl/feature/pretooluse-ask-all-tools
0640bd5 
feat(hooks): support ask reviews for PreToolUse
Pimpmuckl added a commit that referenced this pull request Jul 14, 2026
@Pimpmuckl
Merge pull request #30 from Pimpmuckl/feature/pretooluse-ask-all-tools
0a71d2e 
feat(hooks): support ask reviews for PreToolUse
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chatgpt-codex-connector chatgpt-codex-connector[bot] chatgpt-codex-connector[bot] left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@Pimpmuckl