Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: External player button should not be shown on local playlist #60

Closed
4 tasks done
PikachuEXE opened this issue Sep 13, 2023 · 11 comments
Closed
4 tasks done

[Bug]: External player button should not be shown on local playlist #60

PikachuEXE opened this issue Sep 13, 2023 · 11 comments
Labels
bug Something isn't working
Milestone
Local Playlist v1

Comments

@PikachuEXE
Copy link
Owner

Guidelines

  • I have encountered this bug in the latest release of FreeTube.
  • I have searched the issue tracker for a bug report that matches the one I want to file, without success.
  • I have searched the documentation for information that matches the description of the bug I want to file, without success.

Describe the bug

  • Enable external player
  • View local playlist tab

Expected Behavior

No external player button on local playlists

Issue Labels

usability issue, visual bug

FreeTube Version

934b584

Operating System Version

MacOS

Installation Method

other

Primary API used

Local API

Last Known Working FreeTube Version (If Any)

No response

Additional Information

No response

Nightly Build
@PikachuEXE PikachuEXE added the bug Something isn't working label Sep 13, 2023
@PikachuEXE PikachuEXE added this to the Local Playlist v1 milestone Sep 13, 2023
@PikachuEXE
Copy link
Owner Author

Should be fixed by ca5f045

@PikachuEXE
Copy link
Owner Author

PikachuEXE commented Sep 19, 2023 •
edited
Loading

Also fixed issue about video with local playlist in local playlist view & history view
a3381cb
db6e2bc

Update 1: another fix 2fd43b5

@efb4f5ff-1298-471a-8973-3d47447115dc
Copy link
Collaborator

Im not sure what External player button ur talking about

@PikachuEXE
Copy link
Owner Author

Open in external player button

@efb4f5ff-1298-471a-8973-3d47447115dc
Copy link
Collaborator

i still see that button on hover?

@PikachuEXE
Copy link
Owner Author

The button for user playlist is hidden
But for video the external player should play the video without playlist (coz player would expect online playlist)

I can make the button hidden is confusing (but can almost be hidden in user playlist view, not history view)

@PikachuEXE
Copy link
Owner Author

Just made another fix 6e9636f
Logic reversed ._.

@efb4f5ff-1298-471a-8973-3d47447115dc
Copy link
Collaborator

Ok im just being dumb but can u maybe make a screenshot of the button u have now hidden

@PikachuEXE
Copy link
Owner Author

OK, I am just too lazy to take screenshot until needed :P

All local playlist list view - hidden
image

Single local playlist view video - shown (and I am not sure if this should be shown or not :P)
image

History view for video entry with last played with a local playlist - shown (definitely should be shown but without passing local playlist to external player)
image

@efb4f5ff-1298-471a-8973-3d47447115dc
Copy link
Collaborator

im also not sure if it should be shown on NR 2 but if we choose for it to be hidden then it maybe also should be hidden on these 2 places

VirtualBoxVM_D06YAZpWnv.mp4

@PikachuEXE
Copy link
Owner Author

Leave it as is until more input available (I don't use external player at all...)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
Local Playlist v1
Development

No branches or pull requests
2 participants
@PikachuEXE @efb4f5ff-1298-471a-8973-3d47447115dc