Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Service Name Portability #23

Open
t-lin opened this issue Jul 15, 2020 · 1 comment
Open

Service Name Portability #23

t-lin opened this issue Jul 15, 2020 · 1 comment
Labels
enhancement New feature or request

Comments

@t-lin
Copy link
Member

t-lin commented Jul 15, 2020

Currently when creating and adding a service, one of the key params is the service-name. This service named is the human-readable component of the service, and is automatically coded into the list of CLI params for the proxy.

  • e.g. If I run registry-cli add with a service name asdf, then the resulting image will hard-code asdf into the container's CMD as one of the parameters for the proxy.

If I then go to a new P2P network, run registry-cli add there with the -use-existing-image to pull it from Docker, but with a different service name (e.g. asdf2), then when that container starts, it'll try to find asdf from the new network's registry and fail to find it. This makes the service un-usable.

@t-lin
Copy link
Member Author

t-lin commented Jul 15, 2020

Potential solution: PhysarumSM/service-manager#60

If implemented, the registry-cli's auto-build process should be updated to ensure the new environment variable is picked up in the container images.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant