Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cache update function is not parallelized and could lead to contention when there are a lot of peers in cache. #56

Open
mwyzhao opened this issue Jul 9, 2020 · 3 comments
Assignees

Comments

@mwyzhao
Copy link
Member

mwyzhao commented Jul 9, 2020

As the peer cache fills with peers, the sequential pinging strategy of might cause contention to other pcache operations that the proxy or other users (none that I know of other than proxy) might be requesting. Look into parallelizing the update function so it can run in a timely manner.

@mwyzhao mwyzhao self-assigned this Jul 22, 2020
@mwyzhao
Copy link
Member Author

mwyzhao commented Jul 22, 2020

@t-lin @hivanco do you guys have any sort of setup for testing I can test the new changes on. It's been way too long since I ran the system and I'm a bit out of the loop.

@t-lin
Copy link
Member

t-lin commented Jul 22, 2020

@michaelweiyuzhao You can use the VM 10.11.69.7, I've put your public key from client1 in there. The services are in a screen called p2p (attach via screen -x p2p). It's an all-in-one node so bootstrap, allocator, proxy, and registry are all there in different tabs of the screen.

@t-lin
Copy link
Member

t-lin commented Aug 2, 2020

@michaelweiyuzhao Note that I've just finished #62 and updated the pcache implementation, so hopefully you can pull those changes without conflict.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants