From 62e773e291273605e3888a8b5590abf439dbcc32 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?C=C3=A9dric=20Luthi?= Date: Sun, 8 Feb 2026 18:25:49 +0100 Subject: [PATCH] Actually use the async code paths for bulk insert Since its introduction in 045033c26e3d6cb4c2d989af70d72bfe592a5465, the `sync` argument passed to `BulkInsert()` has always been hardcoded to `false` instead of forwarding the `sync` parameter. As a result, the async code paths for bulk insert in all providers would never be used. This can be confirmed by running code coverage. --- .../BulkInsertProviderBase.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/PhenX.EntityFrameworkCore.BulkInsert/BulkInsertProviderBase.cs b/src/PhenX.EntityFrameworkCore.BulkInsert/BulkInsertProviderBase.cs index 26d2610..852ce08 100644 --- a/src/PhenX.EntityFrameworkCore.BulkInsert/BulkInsertProviderBase.cs +++ b/src/PhenX.EntityFrameworkCore.BulkInsert/BulkInsertProviderBase.cs @@ -144,7 +144,7 @@ private async Task PerformBulkInsertAsync( activity?.AddTag("tempTable", tempTableRequired); activity?.AddTag("synchronous", sync); - await BulkInsert(false, context, tableInfo, entities, tableName, columns, options, ctk); + await BulkInsert(sync, context, tableInfo, entities, tableName, columns, options, ctk); return tableName; }