Just use strptime for all python versions

Author: Perseudonymous

src/datapoint/Forecast.py

@@ -1,5 +1,4 @@
 import datetime
-from platform import python_version
 
 from datapoint.exceptions import APIException
 from datapoint.weather_codes import WEATHER_CODES
@@ -110,21 +109,13 @@ def __init__(self, frequency, api_data):
         :type api_data: dict
         """
         self.frequency = frequency
-        if python_version() < "3.11":
-            # Need to parse format like 2024-02-17T15:00Z. This can only be
-            # done with datetime.datetime.fromisoformat from python 3.11
-            # onwards. Using this if statement to remember to remove the
-            # explicit strptime in the future, and it annoyed me that
-            # fromisoformat couldn't handle all iso-formatted datetimes.
-            data_date = datetime.datetime.strptime(
-                api_data["features"][0]["properties"]["modelRunDate"],
-                "%Y-%m-%dT%H:%M%z",
-            )
-        else:
-            data_date = datetime.datetime.fromisoformat(
-                api_data["features"][0]["properties"]["modelRunDate"]
-            )
-        self.data_date = data_date  #: The date the provided forecast was generated.
+        # Need to parse format like 2024-02-17T15:00Z. This can only be
+        # done with datetime.datetime.fromisoformat from python 3.11
+        # onwards.
+        self.data_date = datetime.datetime.strptime(
+            api_data["features"][0]["properties"]["modelRunDate"],
+            "%Y-%m-%dT%H:%M%z",
+        )  #: The date the provided forecast was generated.
 
         self.forecast_longitude = api_data["features"][0]["geometry"]["coordinates"][
             0
@@ -173,30 +164,16 @@ def _build_timesteps_from_daily(self, forecasts, parameters):
 
         timesteps = []
         for forecast in forecasts:
-            if python_version() < "3.11":
-                # Need to parse format like 2024-02-17T15:00Z. This can only be
-                # done with datetime.datetime.fromisoformat from python 3.11
-                # onwards. Using this if statement to remember to remove the
-                # explicit strptime in the future, and it annoyed me that
-                # fromisoformat couldn't handle all iso-formatted datetimes.
-                night_step = {
-                    "time": datetime.datetime.strptime(
-                        forecast["time"], "%Y-%m-%dT%H:%M%z"
-                    )
-                }
-                day_step = {
-                    "time": datetime.datetime.strptime(
-                        forecast["time"], "%Y-%m-%dT%H:%M%z"
-                    )
-                    + datetime.timedelta(hours=12)
-                }
-
-            else:
-                night_step = {"time": datetime.datetime.fromisoformat(forecast["time"])}
-                day_step = {
-                    "time": datetime.datetime.fromisoformat(forecast["time"])
-                    + datetime.timedelta(hours=12)
-                }
+            # Need to parse format like 2024-02-17T15:00Z. This can only be
+            # done with datetime.datetime.fromisoformat from python 3.11
+            # onwards.
+            night_step = {
+                "time": datetime.datetime.strptime(forecast["time"], "%Y-%m-%dT%H:%M%z")
+            }
+            day_step = {
+                "time": datetime.datetime.strptime(forecast["time"], "%Y-%m-%dT%H:%M%z")
+                + datetime.timedelta(hours=12)
+            }
 
             for element, value in forecast.items():
                 if element.startswith("midday"):
@@ -260,17 +237,12 @@ def _build_timestep(self, forecast, parameters):
         timestep = {}
         for element, value in forecast.items():
             if element == "time":
-                if python_version() < "3.11":
-                    # Need to parse format like 2024-02-17T15:00Z. This can only be
-                    # done with datetime.datetime.fromisoformat from python 3.11
-                    # onwards. Using this if statement to remember to remove the
-                    # explicit strptime in the future, and it annoyed me that
-                    # fromisoformat couldn't handle all iso-formatted datetimes.
-                    timestep["time"] = datetime.datetime.strptime(
-                        forecast["time"], "%Y-%m-%dT%H:%M%z"
-                    )
-                else:
-                    timestep["time"] = datetime.datetime.fromisoformat(forecast["time"])
+                # Need to parse format like 2024-02-17T15:00Z. This can only be
+                # done with datetime.datetime.fromisoformat from python 3.11
+                # onwards.
+                timestep["time"] = datetime.datetime.strptime(
+                    forecast["time"], "%Y-%m-%dT%H:%M%z"
+                )
 
             elif element == "significantWeatherCode":
                 timestep[element] = {