diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index 67e213c1..16305ed8 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -2,7 +2,6 @@ ## Changes Made - ## Checklist @@ -26,5 +25,4 @@ Before submitting this PR, please ensure: Make sure to follow the [CONTRIBUTING.md](https://github.com/Perfect-Abstractions/Compose/blob/main/CONTRIBUTING.md) guidelines. ## Additional Notes - diff --git a/.github/workflows/slither.yml b/.github/workflows/slither.yml index 6026b044..84efe70c 100644 --- a/.github/workflows/slither.yml +++ b/.github/workflows/slither.yml @@ -30,6 +30,7 @@ jobs: run: | pip install slither-analyzer + # Slither analysis ONLY FOR REPORTING PURPOSES - name: Run Slither analysis run: | - slither . --exclude-dependencies \ No newline at end of file + slither . --exclude-dependencies --fail-none \ No newline at end of file diff --git a/src/diamond/DiamondCutFacet.sol b/src/diamond/DiamondCutFacet.sol index 07d32583..cdbef263 100644 --- a/src/diamond/DiamondCutFacet.sol +++ b/src/diamond/DiamondCutFacet.sol @@ -108,7 +108,7 @@ contract DiamondCutFacet { bytes4 lastSelector = ds.selectors[selectorCount]; ds.selectors[oldFacetAddressAndSelectorPosition.selectorPosition] = lastSelector; ds.facetAddressAndSelectorPosition[lastSelector].selectorPosition = - oldFacetAddressAndSelectorPosition.selectorPosition; + oldFacetAddressAndSelectorPosition.selectorPosition; } // delete last selector ds.selectors.pop();