Skip to content

[TESTING] Gas testing the new functionFacetPairs() function #249

@mudgen

Description

@mudgen

Testing Issue

There is a new proposal for a new standard for diamonds, which is here.

There is a question about this: If a diamond has thousands of functions will the functionFacetPairs() function not work because it is too much gas?

So we need to gas test it, to see how many functions it can return. This function is meant to be called offchain.

Major RPC providers such Alchemy and Infura have max gas cap limits up to around 550 million gas.

I want to see how many selector/facet pairs the functionFacetPairs() function can return using these amounts of gas:

  1. 10 million gas
  2. 50 million gas
  3. 100 million gas
  4. 300 million gas
  5. 500 million gas

The implementation of functionFacetPairs() to test is here:
https://gist.github.com/mudgen/92a2e53b9a59817012dba2c72c8d84aa

Please submit a pull request with the code and a report that shows the gas test results.

This issue is time sensitive, it would be good if this could be done today.

Helpful Information

Have a question? Please check our contribution guide first - your answer might already be there!

Want to discuss something? For general questions, ideas, or brainstorming, please browse our discussions or start a new one.

You can also join our Discord to discuss the testing issue.

Metadata

Metadata

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions