Review the code for bugs and security vulnerabilities

[mudgen]

If you find any bugs or security issues, please report them here or in a new issue.

[shubu258]

hey , I am a security researcher and developer would like to audit your contract . I you can assign me the issue here , i have total of 1 year of experience doing auditing and have 25 findings in my portfolio with 3 critical, 6 High, 4 Medium , 10 Low.

[shubu258]

I have taken a overview of your contract , i found few gas optimization and certain function which can follow best security practices . Should i make a request ?

[mudgen]

Yes, make an issue or pull request or both.

[shubu258]

okay cool

[farismln]

Hi @mudgen is it intended that ERC20Facet.sol does not implement external mint function?
where can I read more about what function that should/should not be added in ERCs Facet?

I want to learn more about this.
thanks

edit: maybe because usually mint is a privileged function and Compose try to not using modifier?

[mudgen]

@farismln A mint external function would require authentication which we don't have in ERC20Facet.sol.

Remember we are making composable, reusable, onchain facets.

So someone making a diamond would add all the external functions from the deployed ERC20Facet to their diamond. And to have external mint functionality such a user would make their own custom facet with an external mint function (which used LibERC20.sol), and they would deploy their custom facet and add its functions to their diamond.

I certainly need to write more user documentation to show how Compose is intended to be used by users.

[adamgall]

@mudgen is there expected to be an explicit deliverable for this issue?

[mudgen]

@adamgall No, so I am converting this to a discussion.

[megabyte0x]

I am not sure if we can call it bug but the IncorrectFacetCutAction error is unreachable.

Reason: We accept the action param in enum and it won't be possible to have any value other than 0,1, and 2 to get compiled and pass.