Skip to content

Commit c0fbad7

Browse files
authored
Merge pull request #14 from PerchAnton/edit-session/beta-field-trial
Show how to evaluate stale-draft protection in a second dialog
2 parents ae1fb57 + d9954be commit c0fbad7

2 files changed

Lines changed: 22 additions & 0 deletions

File tree

‎README.md‎

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -42,6 +42,13 @@ and checked in CI. [Walkthrough and host responsibilities](docs/CONTEXT_WALKTHRO
4242
The host supplies stable identities, advances revisions, and keeps the check and
4343
command on the same serialized edit path. A correct local helper can provide the
4444
same protection; this example does not claim less code or faster execution.
45+
46+
**Would this earn a place in your editor?** In a proposed PdfCraft fix, two native
47+
regressions went from 0/2 passing to 2/2. One protected a newer title and the other
48+
preserved Redo. The full patch added a net 217 production UI lines. If two dialogs
49+
in your editor have this problem, try a local helper and the crate against the
50+
same tests. [What to measure in the second dialog](docs/ADOPTION.md#try-a-second-dialog).
51+
4552
The separate [interaction-check](https://github.com/PerchAnton/interaction-check)
4653
development tool is optional. Neither project depends on the other.
4754

‎docs/ADOPTION.md‎

Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -86,3 +86,18 @@ PhotoCraft and PdfCraft are proposed consumers, not adopted dependencies. We hav
8686
demonstrated behavior protection in a consumer patch; we have not demonstrated lower
8787
total source size or faster editing. The next valuable milestone is a maintainer-reviewed
8888
workflow and ownership decision, not more adapters or a larger API.
89+
90+
## Try a second dialog
91+
92+
Pick two dialogs in the same editor that share a document revision but edit
93+
different fields. In each, type a draft, apply a change elsewhere, undo that
94+
change, then confirm the old draft. Record the resulting value and whether Redo
95+
still works. Use the same native assertions for both implementations.
96+
97+
Start with the editor's smallest correct helper. On a separate branch try
98+
`edit-session`, keeping the same command dispatch and revision source. For the
99+
second dialog, record which checks you reused, which host-specific code you
100+
had to write and the production lines added or removed. Count tests separately.
101+
If both versions pass and the second dialog reuses as much with the local
102+
helper, keep the helper. A useful trial result is the pair of diffs and tests,
103+
including the cases where the crate added work.

0 commit comments

Comments
 (0)