Skip to content

Multiple More critical damage bonus are not being calculated correctly #1042

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
3 tasks done
farees5633 opened this issue Apr 20, 2025 · 2 comments · Fixed by #1044
Closed
3 tasks done

Multiple More critical damage bonus are not being calculated correctly #1042

farees5633 opened this issue Apr 20, 2025 · 2 comments · Fixed by #1044
Labels
bug: calculation Numerical differences

Comments

@farees5633
Copy link

Check version

  • I'm running the latest version of Path of Building and I've verified this by checking the changelog

Check for duplicates

  • I've checked for duplicate open and closed issues by using the search function of the issue tracker

Check for support

  • I've checked that the calculation is supposed to be supported. If it isn't please open a feature request instead (Red text is a feature request).

What platform are you running Path of Building on?

Windows

What is the value from the calculation in-game?

a

What is the value from the calculation in Path of Building?

if I have 30% more crit damage bouns and 15% more another, crit damage bouns x 1.3 x 1.15 is correct. but PoB calculate as crit damage bonus x (1+0.3+0.15)

How to reproduce the issue

add Blindside and Overextend support or Pain Attunment node

PoB for PoE2 build code

a

Screenshots

No response
@LocalIdentity
Copy link
Contributor

Please provide a build code for your issue

@LocalIdentity LocalIdentity mentioned this issue Apr 20, 2025
Merged
@Blitz54 Blitz54 added the bug: calculation Numerical differences label Apr 23, 2025
@OrderedSet86
Copy link
Contributor

Seems like a fix is already on the way, but here is a build code:

eNqlW1tz4rgSfp75FS5OnTcGbGNz2SK7RUgyyUxuE5LZ2fOypdgCPCNbrC0nYX_9aV1sTIKMTFI1CVj9dUt9U6vlGf_xEhPrCadZRJOjltOxWxZOAhpGyeKo9XB_9mnY-uP3j-NbxJY38-M8InzE_f3jh7H4YhH8hMlRyx22rICgLLtGMT5q3aFkgdOWhbIAJ-F0M3BNE9yyGEoXmH0vpNp_O4BeohQFDKeXnOMkZ_SKhoBgaQ6IGEXJjAa_MPuc0nwFM21ZTxF-ljQXV7c3d_ctmNWH8S1Ba5zOGGJWBr-OWhNYHVrgExTDb0AhkgPE6_mdYb836jkDr-d5rW4t-DhPM3YYh9kK47AEOR0t4W2KT-dzHLDoCU_TiE2XKAk24vzOwNdBDyC_ygmLViTiVlIQt-NpIedvBDi2rSO-pwyRk9tZSdt37I5rj3zb8zx76NTjKCtxWgl_Rmx5TECxB0jh2ItFEjF8APiWRhlNtoBurzO0e7bdG9huf1Qn9S3YcXtex3ZcH0SCP-1TzAFypzkhELFVpFardzjD6RNi0fYktfRTGj9GybYRDFc0STG6mUt_v0NhlGdXmKU4qwSKFnuFEjSlmYGbcMpbnEIOYo0AMxxQSFtNZTREXkZzbE7ZaB0K0HQ2h63jdGZK15jxYRO6gzRtRjmjOTGkZJtE6fiujuwEv1TIdFQXyUbiQM_qifJQ3D83kR5Oz283kkdup9f3_J5rOyOtgNvlOosCRK7QSxTnMaT4e_QLb-S53kjvLIslSyCv6LDOYKjDnkUpPgA2pSQ8BLZENDtghVdQcJyjJJwEQQ51ybpi1b4N_7RWQ-mvBGeZabaF7GmM4CG68RvHrik5gt848UUSbAqCOq4PSapmY8KfI-4gHnlt9EhwRZ3DjqEYFdgm1YSUtsCJErk2U9QlxsHyM1jxDjFslsarNq7VLSeu6raW6w7d1vDfRjRQEwfuVlO_49aBGipqtoqgfDSZkaTctXxzTAMFnCY4XaxnywiT0GBvqVAXGpuilcn6wQGqaCNH2BbXyJmr0Ia24hthU2lPKKtuOo47qNeEpDeLBgwlOwBC_OosYevPRPQnPxGRZrBJGtM8NbSlJDZaQLFjypPgHQ7zwGyHLg92xwQOsabLKFEwT0IaQSeMoeDXCQ0XxkoTQhohtuc3y1crCFvuDaYMeCkA22BUKcA-eQbUN-DLRsHKiwZzARtqYwFlIWQu5RXEfC28knklxoTYWEBpzivIFTFkXdG6uKKVxK01DZwyjY6MgnD7IKuPNvoMM1_yXlHWjBrqvRLQ004lxcm_a2P-W-RGAk6TEEpHCARjGa8Ru8Qc5_N5ZgVw9EbsEsx71GpZj_Cs-AzlaobVF4m4j2JIvFl2ghiyQnWq-I7SCCXMFZ20DKM0WHLQGSLkETIH57R5yr-9AjqFN4y7ohHIP13EK5oyC7_wP7coZeuj1hyRDEtC8QT4ZCxKRJMB0hQhLWu2pM-T8Imv-55SkhUgC61WOAm3eNynGFuoSDoBn4RYI_9ixShjsMlJP874pCv9x4uQK95KKEwAtNnvu6O2Dwclp-3bnj9quwN31G97o74_aDt9bzhq93u-22-7Tm84aLv9geu3fQDYbafneg78HrrDtj8Y2L223xs4o7bnDPrwZDQYAAfftwdt3xs6Ttsd-j5wBqZ9GB0OAet4dtsb9gfATDAe9IGX49o2QIANQEZDF373gAI4eYLt0IcpAbTt2CMbxA09W9iOH4xRup5srzWJQLUM1FVps7qqSSt1wRX3Yfxwdyk-fFgytsp-63afn587K8SWdI5fYOPtgKt1VwAClX_KfkWEfOJcuxP4OV5MJhd_Db-v2dk_9Orc__Y58b6Qm0v0-ccP8vPGv17cL_83Ov9B1z9Xi_v1vbNkTz-_fs37-NdpeOnhb98fwn8ns2fny9nLdTyYOc8_V9Ecff26cken3yYTMcFuMcOxbABnXfmN57U0AmvK6Y9hy0ujx5zhYgBc7eVamrtlRQkrP2csvX7rBtJkW27AzVT1BaFypf6qVaWPSBNJC1fNKA0tTKycQziQsiU3ujJ0xZekW0j_EX7VUqvubi173OWOL6KQRwb_cE2ZHOMPiy_jGTdcZmUQmJ9xnB2vIQOf8YryVRdPhRannmEmk0MVU_TjQzxHOeHPv-WIRDzS7erTS3ktkNA0LhsMwAoinZcJkuP9esVtMLm8VDGspFpRWMS1eija_5PN1KaIBJmYXJQEJA_hoKt2IOX3BD1y8fwug59Qw-o1QoVPKebDGOajiD8T-oiIW0CKCw67tTXuFONPMh_ykJIRCHlsLTu9NM-mNAmoKhJF8HC6HaNyK2hZ_1S0ucAxp77CDIWQursXDKzQhYl2xeThwx6BCYpVliyHrer4K-UENE9Yuckb6MTZr5JjEiVhBu6qzF7RgnpSUjRUQelGJYPqgisP61c5lspUwaQ8UASUDBn-UbiboLhIVjkTYo5acZQFf_Odl99BiaQi7sxOz85Op_cX30_V7luFiLX_neTxI1-o_LupqmZY2MXK8sdMfjxqfY_ws5jICaggIhmfPyFoleFyXxThomZOAFfDTVCdR-VN1m5eGwI9p9MXnMI2vvgTSoQ0wtp5leN7JiUF8jMqr1Z03PjdkJ6RPPNMoQiQp2ONpsR9nJ4LvxzTLocP1mChAEJEK1mN7tEE41kRfDiaRwEvDetNznOopKrRS9nC1NpbHdj0PMRlm46BHNSDZfbRodVojVbFZZ1Wq3JUDz_BAdKuXQ7qwWXDhSbnvOu1m0tJVcPpmibCySFoJhHhxyutZU8JLkn0DG_YEqeq1tVxuoIcVZDUBo6snLR8KhQ1uhLtaY2G-JgeKruvmjXwsZqgUf1IXbRH9SG73TXU2KNKo2clj9taHaqje40ZVNdKYwI5WrOSonOnWYQargkUkYMnTzQKZftGEzKvyOqSBhTs72cjelLvZ_O6SfV-jmdwlvqltbca1cMfWMQLnR1cZKVixIQH1vs48Ph6HwferYgPRt-9LkU22Lv6IqTsq-wEF6N1sa_aLQdzkE2hg-GiZ3UwWmwAJ3iOYQW1O0BJUxMcLE9OQBmsJjAMWYlp7c4im9U14iX3wp0rbcxRRre6Bq5LAJJkDyPYzM9rykUzTmXf9Rwjwt8SouR9DN9cd7-HGb86ylcoCQt2N7uK9I0dDLVHWQY8RevwhN9QvVeHCY7XOxjp5zXuFsc60VTkBy3V8ZwxOJQhBhEhuuAt619K4794C2DU6fWGriefqBbHULU1oAg_icCSqfDAQjIn_HHUGoy8juPbA3kROxbHWNVr4Z_LVoueUZ5h-QrMnxitaCIQvNUhz5iSh5Zou6NCKLOgZI5vHx_uLnmTRB5O4RD_xKOLD8kGYbceIIVYTnOI2wByBzFm9RoAjillO5chuocXIRCLLjAfFA3dAvgFP2NiqUdVxoZ6sGbP_JrFeKKTOCeYNVVFE92JjXm38nYoQ_S4t5WhHjVQhhTZfJKHeFFThR9j0kTdonJpNLFzDDtVY4s6jZw7XFvFQaHhSt4aZdxVmUPkQ5GVRL-LJvNoofKT_KIylACVT7bSSrXPxVNQxBPzJX2Wp8JH2NQwSlQ26-6A5Bmj8RUNs00r7T9WFsUrwjshojD56Nji57-87ZtiBBkeJqmaG92aaYjdQbQEeRNj51xuCQrwkpIQpwqNOUi9vV206ga2vQewdUtbwPaByivhojFXAEd9f5-8yqvfBaoGM1tC4M94nyx704DUy4AnzWfGr-ubo8SuugEMXT19XL7Czl-uhv0yFAub8gbvDJN5ZYG-wQpfG803ttotr7EKWM8U1VheecAvlePtE7b9wkojv-J-_BrWG_YN3JELhBQtXmp87WruvkWegE62vXkvhBvP1AQbn-EnngTzd7-gxiNro2ioeBzva68fsoYMysBoYvxZQEVVahy0WbSIyM1cnC4BJo7IppMr9pbSx-z-PidTb0NB0S3-2081Wxp4yxsfsw3UZ2ru6ZJfi-zWHBwAio1MHgfEt98_jrtv_rPT_wF5HROa

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug: calculation Numerical differences
Projects
None yet
Milestone
No milestone
4 participants
@Blitz54 @LocalIdentity @OrderedSet86 @farees5633