Merge branch 'master' into enhancement/add-extra-data

Author: joshuarrrr

.eslintrc

@@ -15,7 +15,7 @@
     "es6": true,
     "browser": true
   },
- "parserOptions": {
+  "parserOptions": {
     "ecmaVersion": 6,
     "sourceType": "module"
   },
@@ -33,7 +33,7 @@
         "file": "fileoverview",
         "returns": "return"
       },
-      "allowOverrideWithoutParam" : true
+      "allowOverrideWithoutParam": true
     }
   },
   "rules": {
@@ -43,25 +43,28 @@
     "curly": 2,
     "google-camelcase/google-camelcase": 2,
     "jsdoc/check-param-names": 2,
-    "jsdoc/check-tag-names": [2, {
-      "definedTags": [
-        "closurePrimitive",
-        "deprecated",
-        "dict",
-        "export",
-        "final",
-        "nocollapse",
-        "noinline",
-        "package",
-        "record",
-        "restricted",
-        "struct",
-        "suppress",
-        "template",
-        "visibleForTesting"
-      ]
-    }],
-    "jsdoc/check-types": [2, { "noDefaults": true }],
+    "jsdoc/check-tag-names": [
+      2,
+      {
+        "definedTags": [
+          "closurePrimitive",
+          "deprecated",
+          "dict",
+          "export",
+          "final",
+          "nocollapse",
+          "noinline",
+          "package",
+          "record",
+          "restricted",
+          "struct",
+          "suppress",
+          "template",
+          "visibleForTesting"
+        ]
+      }
+    ],
+    "jsdoc/check-types": [2, {"noDefaults": true}],
     "jsdoc/require-param": 2,
     "jsdoc/require-param-name": 2,
     "jsdoc/require-param-type": 2,
@@ -111,7 +114,7 @@
     "no-eval": 2,
     "no-extend-native": 2,
     "no-extra-bind": 2,
-    "no-implicit-coercion": [2, { "boolean": false }],
+    "no-implicit-coercion": [2, {"boolean": false}],
     "no-implied-eval": 2,
     "no-iterator": 2,
     "no-lone-blocks": 2,
@@ -123,16 +126,23 @@
     "no-sequences": 2,
     "no-throw-literal": 2,
     "no-unused-expressions": 0,
-    "no-unused-vars": [2, {
-      "argsIgnorePattern": "^(var_args$|opt_|unused)",
-      "varsIgnorePattern": "(AmpElement|Def|Interface)$"
-    }],
+    "no-unused-vars": [
+      2,
+      {
+        "argsIgnorePattern": "^(var_args$|opt_|unused)",
+        "varsIgnorePattern": "(AmpElement|Def|Interface)$"
+      }
+    ],
     "no-useless-call": 2,
     "no-useless-concat": 2,
     "no-undef": 2,
     "no-var": 2,
-    "no-warning-comments": [2, { "terms": ["do not submit"], "location": "anywhere" }],
-    "notice/notice": [2,
+    "no-warning-comments": [
+      2,
+      {"terms": ["do not submit"], "location": "anywhere"}
+    ],
+    "notice/notice": [
+      2,
       {
         "mustMatch": "Copyright 20\\d{2} The AMP HTML Authors\\.",
         "templateFile": "build-system/common/LICENSE-TEMPLATE.txt",
@@ -141,24 +151,30 @@
         }
       }
     ],
-    "object-shorthand": [2, "properties", { "avoidQuotes": true }],
+    "object-shorthand": [2, "properties", {"avoidQuotes": true}],
     "prefer-const": 2,
     "prettier/prettier": 2,
     "radix": 2,
-    "require-jsdoc": [2, {
-      "require": {
-        "FunctionDeclaration": true,
-        "MethodDefinition": true,
-        "ClassDeclaration": false,
-        "ArrowFunctionExpression": false,
-        "FunctionExpression": false
+    "require-jsdoc": [
+      2,
+      {
+        "require": {
+          "FunctionDeclaration": true,
+          "MethodDefinition": true,
+          "ClassDeclaration": false,
+          "ArrowFunctionExpression": false,
+          "FunctionExpression": false
+        }
+      }
+    ],
+    "sort-imports-es6-autofix/sort-imports-es6": [
+      2,
+      {
+        "ignoreCase": false,
+        "ignoreMemberSort": false,
+        "memberSyntaxSortOrder": ["none", "all", "multiple", "single"]
       }
-    }],
-    "sort-imports-es6-autofix/sort-imports-es6": [2, {
-      "ignoreCase": false,
-      "ignoreMemberSort": false,
-      "memberSyntaxSortOrder": ["none", "all", "multiple", "single"]
-    }],
+    ],
     "sort-requires/sort-requires": 2
   },
   "overrides": [

.github/ISSUE_TEMPLATE/intent-to-implement--i2i-.md

@@ -36,7 +36,11 @@ A clear and concise description of any alternative solutions or features you've
 <!--
 Add any other information that may help people understand your I2I.
 -->
-
+## Launch tracker
+<!--
+The launch tracker is meant to be an easy way of sharing a project's status with others on the AMP Project. 
+You should add a link to the launch tracker for this work here if applicable. One ideal template and instructions can be found here: bit.ly/amp-launch-tracker
+-->
 
 <!--
 Add anyone to this cc line that you want to notify about this I2I, including a reviewer once you have found one. See https://github.com/ampproject/amphtml/blob/master/CONTRIBUTING.md for help in finding a reviewer.

.github/OWNERS

@@ -4,10 +4,7 @@
 {
   rules: [
     {
-      owners: [
-        { name: 'ampproject/wg-outreach' },
-        { name: 'ampproject/wg-infra' }
-      ]
-    }
-  ]
+      owners: [{name: 'ampproject/wg-outreach'}, {name: 'ampproject/wg-infra'}],
+    },
+  ],
 }

.gitignore

@@ -12,7 +12,6 @@ npm-debug.log
 .idea
 .tm_properties
 .settings
-.vscode
 typings
 typings.json
 build-system/runner/dist
@@ -22,8 +21,6 @@ test/coverage
 *.swp
 *.swo
 yarn-error.log
-PERCY_BUILD_ID
-chromedriver.log
 sc-*-linux*
 sc-*-osx*
 sauce_connect_*

.lando.yml

@@ -43,35 +43,35 @@ tooling:
     service: appserver
   gulp:
     service: appserver
-    cmd: "yarn gulp"
+    cmd: 'yarn gulp'
   watch:
     service: appserver
-    cmd: "yarn gulp watch"
-    description: "Watches for changes in files, re-builds when detected"
+    cmd: 'yarn gulp watch'
+    description: 'Watches for changes in files, re-builds when detected'
   lint:
     service: appserver
-    cmd: "yarn gulp lint"
-    description: "Validates against Google Closure Linter"
+    cmd: 'yarn gulp lint'
+    description: 'Validates against Google Closure Linter'
   check-types:
     service: appserver
-    cmd: "yarn gulp check-types"
-    description: "Check source code for JS type errors"
+    cmd: 'yarn gulp check-types'
+    description: 'Check source code for JS type errors'
   dist:
     service: appserver
-    cmd: "yarn gulp dist"
-    description: "Build production binaries"
+    cmd: 'yarn gulp dist'
+    description: 'Build production binaries'
   unit:
     service: appserver
-    cmd: "yarn gulp unit"
-    description: "Run unit tests"
+    cmd: 'yarn gulp unit'
+    description: 'Run unit tests'
   integration:
     service: appserver
-    cmd: "yarn gulp integration"
-    description: "Run integration tests"
+    cmd: 'yarn gulp integration'
+    description: 'Run integration tests'
   e2e:
     service: appserver
-    cmd: "yarn gulp e2e"
-    description: "Runs e2e tests"
+    cmd: 'yarn gulp e2e'
+    description: 'Runs e2e tests'
 
 proxy:
   appserver:

.lgtm.yml

@@ -1,15 +1,15 @@
 path_classifiers:
   docs:
-    - "**/*.md"
+    - '**/*.md'
   test:
-    - "**/test/**/*.js"
-    - "**/testing/**/*.js"
+    - '**/test/**/*.js'
+    - '**/testing/**/*.js'
   third_party:
-    - "third_party/**/*.*"
+    - 'third_party/**/*.*'
   externs:
-    - "**/*.extern.js"
+    - '**/*.extern.js'
   build-system:
-    - "build-system/**/*.*"
+    - 'build-system/**/*.*'
 extraction:
   javascript:
     index:

.prettierrc

@@ -2,5 +2,19 @@
   "bracketSpacing": false,
   "singleQuote": true,
   "trailingComma": "es5",
-  "quoteProps": "preserve"
+  "quoteProps": "preserve",
+  "overrides": [
+    {
+      "files": "OWNERS",
+      "options": {"parser": "json5"}
+    },
+    {
+      "files": [".eslintrc", ".prettierrc", ".renovaterc.json", "*.json"],
+      "options": {"parser": "json"}
+    },
+    {
+      "files": [".codecov.yml", ".lando.yml", ".lgtm.yml", ".travis.yml"],
+      "options": {"parser": "yaml"}
+    }
+  ]
 }

.renovaterc.json

@@ -1,11 +1,7 @@
 {
-  "extends": [
-    "config:base"
-  ],
+  "extends": ["config:base"],
   "node": {
-    "supportPolicy": [
-      "lts_active"
-    ]
+    "supportPolicy": ["lts_active"]
   },
   "statusCheckVerify": true,
   "commitMessagePrefix": "📦",

.travis.yml

@@ -90,15 +90,15 @@ jobs:
       env:
         - CACHE_NAME=E2EJOB
     - stage: experiment
-      name: "Experiment A Tests"
+      name: 'Experiment A Tests'
       script:
         - unbuffer node build-system/pr-check/experiment-tests.js --experiment=experimentA
     - stage: experiment
-      name: "Experiment B Tests"
+      name: 'Experiment B Tests'
       script:
         - unbuffer node build-system/pr-check/experiment-tests.js --experiment=experimentB
     - stage: experiment
-      name: "Experiment C Tests"
+      name: 'Experiment C Tests'
       script:
         - unbuffer node build-system/pr-check/experiment-tests.js --experiment=experimentC
 before_cache:

tools/OWNERS .vscode/OWNERS

@@ -4,11 +4,7 @@
 {
   rules: [
     {
-      owners: [
-        { name: 'ampproject/wg-infra' },
-        { name: 'ampproject/runtime' },
-        { name: 'ampproject/performance' }
-      ]
-    }
-  ]
+      owners: [{name: 'ampproject/wg-infra'}, {name: 'rsimha', notify: true}],
+    },
+  ],
 }

.vscode/settings.json

@@ -0,0 +1,28 @@
+{
+  "files.associations": {
+    // Enable JSON5 syntax highlighting and auto-formatting for OWNERS files.
+    // Until VS Code adds native JSON5 support, this needs
+    // https://marketplace.visualstudio.com/items?itemName=mrmlnc.vscode-json5
+    "OWNERS": "json5",
+
+    // Enable JSON auto-formatting for these files.
+    ".eslintrc": "json",
+    ".prettierrc": "json",
+    ".renovaterc.json": "json",
+    ".codecov.yml": "yaml",
+    ".lando.yml": "yaml",
+    ".lgtm.yml": "yaml",
+    ".travis.yml": "yaml"
+  },
+
+  // Auto-fix JS files with ESLint using amphtml's custom settings. Needs
+  // https://marketplace.visualstudio.com/items?itemName=dbaeumer.vscode-eslint
+  "eslint.autoFixOnSave": true,
+  "[js]": {"editor.formatOnSave": false},
+
+  // Auto-fix non-JS files with Prettier using amphtml's custom settings. Needs
+  // https://marketplace.visualstudio.com/items?itemName=esbenp.prettier-vscode
+  "[yaml]": {"editor.formatOnSave": true},
+  "[json]": {"editor.formatOnSave": true},
+  "[json5]": {"editor.formatOnSave": true}
+}

3p/OWNERS

@@ -4,7 +4,7 @@
 {
   rules: [
     {
-      owners: [{ name: 'ampproject/wg-ads' }]
-    }
-  ]
+      owners: [{name: 'ampproject/wg-ads'}],
+    },
+  ],
 }