This repository was archived by the owner on May 13, 2019. It is now read-only.
Fix for incorrect startup display#117
Open
Grimmstar wants to merge 2 commits intoPaqmind:masterfrom
Grimmstar:master
Open
Fix for incorrect startup display#117Grimmstar wants to merge 2 commits intoPaqmind:masterfrom Grimmstar:master
Grimmstar wants to merge 2 commits intoPaqmind:masterfrom
Grimmstar:master
Conversation
By modifying "backend/server.js" and "frontend/state.js", the site now loads correctly.
In "backend/server.js"
...
server.on("listening", () => logger.info("Listening on port " + process.env.HTTP_PORT))
server.listen(process.env.HTTP_PORT);
...
should be (port number should be whatever port user is intending to use)
...
server.on("listening", () => logger.info("Listening on port " + process.env.HTTP_PORT || 3000))
server.listen(process.env.HTTP_PORT || 3000);
...
and in "frontend/state.js"
...
window._state = new Baobab(
{
url: {
route: undefined,
path: undefined,
params: {},
query: {},
},
...
should instead be
...
window._state = new Baobab(
{
url: {
route: '/public',
path: 'http://localhost:3000/public/',
params: {},
query: {},
},
...
Fix server issues
Member
|
Hello @grimm-child. Thank you for this PR! The changes you propose seem reasonable to me. But I'm confused that in the comment above you're mentioning changes to I'm going to revive this project, so I'd like to accept your PR. Just need a clarification on the above. |
Member
|
Hey @grimm-child did you miss a notification bell ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In reference to the many issues being brought up by people who were not able to get the site to start up correctly, and were brought to a folder simply listing the files, I found that this solution worked for me. By modifying "backend/server.js" and "frontend/state.js", the site now loads as intended.
In "backend/server.js"
should be (port number should be whatever port user is intending to use)
and in "frontend/state.js"
should instead be