Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Server link labels are not translated #1483

Open
Krymonota opened this issue Dec 31, 2024 · 0 comments
Open

Server link labels are not translated #1483

Krymonota opened this issue Dec 31, 2024 · 0 comments
Labels
type: bug Something isn't working

Comments

@Krymonota
Copy link

Expected Behavior

When I set a server link with a label using a translation key, I expect the translation key to be resolved so that the player sees the translated string.

Actual Behavior

The translation key is not resolved and the player sees the translation key instead.

Image

Steps to Reproduce

player.setServerLinks(List.of(ServerLink.serverLink(Component.translatable("velocity.kick.shutdown"), "https://example.com")));

Plugin List

No third-party plugins

Velocity Version

Velocity 3.4.0-SNAPSHOT (git-1db8c8c6-b458)

Additional Information

It seems that ConnectedPlayer#translateMessage is not being invoked on the server link label (which I as a plugin developer cannot invoke either, as this function is not part of the API).

@Krymonota Krymonota added the type: bug Something isn't working label Dec 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant