Use book packet for both methods #13298
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
item stack swap technique is dumb af and outright dangerous
Owen1212055
requested changes
Nov 12, 2025
Member
There was a problem hiding this comment.
Thread safety is never a promise for these methods, potentially an async catcher would be useful. The current method cannot ever be made async due to the resolve logic.
This causes a behavior change, as the book item is no longer resolved, which currently openItemGui does.
github-project-automation
bot
moved this from Awaiting review
to Changes required
in Paper PR Queue
Author
Should we be resolving the book in both methods? |
Member
|
No, only the method you are changing. |
to prevent any behaviour change
Owen1212055
reviewed
Nov 12, 2025
paper-server/src/main/java/org/bukkit/craftbukkit/entity/CraftPlayer.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
item stack swap technique is risky, what if openItemGui threw an exception? what if the author (stupidly) called openbook() async, assuming it would just send a packet (which it should), the result would be sometimes the players hand item is deleted and replaced with a book item they shouldn't have.
The only argument in favour of itemstack swap technique is that its less maintenance work than sending packet, but we are already sending packet in a virtually identical method.
#12582
PR untested ATM (Can someone test? 😄)