Add permission nodes for more gamemaster blocks. #13295
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
shouldn't be a feature patch, requireNonNull is dangerous, perm node names leave something to be desired |
Author
|
What do you think would be a better name for the permission nodes? As for "requireNonNull", the IDE suggested that I add that to avoid a NullPointerException. |
|
Its better to use |
Member
|
requireNonNull, works by throwing an exception if the value is null, as does the preconditions, we shouldn't be introducing throws to such a trivial state, validate it |
|
yea that might be smarter, also what is the reason for the unnecessary assert? it should be removed if im seeing correctly |
Author
|
What do you mean by assert? |
Toffikk
reviewed
Nov 16, 2025
| BlockEntity blockEntity = level.getBlockEntity(pos); | ||
| - if (blockEntity instanceof JigsawBlockEntity && player.canUseGameMasterBlocks()) { | ||
| + if (blockEntity instanceof JigsawBlockEntity && player.canUseGameMasterBlocks() || (player.isCreative() && player.getBukkitEntity().hasPermission("minecraft.jigsawblock"))) { | ||
| + assert blockEntity instanceof net.minecraft.world.level.block.entity.JigsawBlockEntity; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I would like to suggest adding permissions for more of the gamemaster blocks that are included in Java Edition. The patch I created adds the following nodes:
• Structure Block ("minecraft.structureblock")
• Jigsaw Block ("minecraft.jigsawblock")
• Light Block ("minecraft.lightblock")
Note: This controls whether or not players can change the light level by interacting with a Light Block with one in their hand.
• Lectern Block ("minecraft.lecternblock")
Note: This permission node controls whether or not a lectern with NBT can be placed. Regular players can still place the block with no NBT.
• Test Block ("minecraft.testblock")
• Test Instance Block ("minecraft.testinstanceblock")