cellspacer.py -- shift from binary files (rb/wb to r/w) creates blank lines in Python 2 output

[stucka]

I'm assuming this works properly in Python 3 else @amikiri wouldn't have submitted patch, but I haven't tested.

[michealbeatty]

Odd, I'm not seeing this issue in either Python 2 or 3. Can I see the source file or a portion thereof?

[stucka]

Should be here: https://gist.github.com/stucka/5e82393945fa7b6cdba7

[stucka]

I'm looking in a text editor, and I've got:
data + cr
nothing + cr + lf
data + cr
nothing + cr + lf

[michealbeatty]

OK, I see it happening when I run the script on Windows. Let me look into fixing this.

[stucka]

Looks like it's a thing written circumspectly about in the docs: https://docs.python.org/2/library/csv.html#csv.writer
via http://stackoverflow.com/questions/1170214/pythons-csv-writer-produces-wrong-line-terminator

Patched with 65adc58 ... and life goes on. =)

[stucka]

Fixed by @amikiri patch in c33dcf3

[stucka]

We're still having problems with this, sadly, such that files created by postgeo.py in Windows aren't readable by cellspacer.py.

I'm thinking the answer might be:
Open CSVs with rU
Write CSVs with w or possibly wb
Don't force csvwriter into any particular behavior

I haven't tested this, however, and my efforts to find best practices have fallen flat.

[michealbeatty]

I'm guessing that adding the same lineterminator argument to csv.writer in postgeo would fix the issue. Let me try that and see if it works.

[stucka]

@amikiri , what happens if you just try with rU and wb?

I tried with rU and w (no b) and got cr-cr-lf with no line terminator argument.

[stucka]

I pushed out a bunch of smallish fixes to postgeo.py in commit f3d9111 , but also tried the rU, wb, no terminator. Works here. No idea if it works on your end. I can test in Linux but don't have easy access to a Mac box.