Chapter03 code doesn't build

[sudarshanchoubey]

/home/source/Learn-LLVM-12/Chapter03/calc/src/CodeGen.cpp: In member function ‘virtual void {anonymous}::ToIRVisitor::visit(WithDecl&)’:
/home/source/Learn-LLVM-12/Chapter03/calc/src/CodeGen.cpp:101:11: error: cannot convert ‘llvm::GlobalVariable*’ to ‘llvm::Type*’
101 | Str, {Int32Zero, Int32Zero}, "ptr");
| ^~~
| |
| llvm::GlobalVariable*
In file included from /home/source/Learn-LLVM-12/Chapter03/calc/src/CodeGen.cpp:3:
/usr/local/include/llvm/IR/IRBuilder.h:1775:34: note: initializing argument 1 of ‘llvm::Value* llvm::IRBuilderBase::CreateInBoundsGEP(llvm::Type*, llvm::Value*, llvm::ArrayRefllvm::Value*, const llvm::Twine&)’
1775 | Value *CreateInBoundsGEP(Type *Ty, Value *Ptr, ArrayRef<Value *> IdxList,
| ~~~~~~^~
make[2]: *** [src/CMakeFiles/calc.dir/build.make:90: src/CMakeFiles/calc.dir/CodeGen.cpp.o] Error 1
make[1]: *** [CMakeFiles/Makefile2:179: src/CMakeFiles/calc.dir/all] Error 2
make: *** [Makefile:91: all] Error 2

Changing the same lines to
Value *Ptr = Builder.CreateInBoundsGEP((llvm::Type *)Str, Int32Zero, Int32Zero, "ptr");
leads to a successful build.
Could you provide a better solution, the casting I have added may not be the best way to write this code.

[Fare9]

Hello I have had the same error, it looks like the call to CreateInBoundsGEP changed on time, in LLVM 12 you were able to find the next code:

Value *CreateInBoundsGEP(Value *Ptr, ArrayRef<Value *> IdxList,
                           const Twine &Name = "") {
    return CreateInBoundsGEP(nullptr, Ptr, IdxList, Name);
}

This method was deleted and only the version with 4 types was kept:

Value *CreateInBoundsGEP(Type *Ty, Value *Ptr, ArrayRef<Value *> IdxList,
                           const Twine &Name = "") {
    return CreateGEP(Ty, Ptr, IdxList, Name, /* IsInBounds */ true);
  }

And you cannot call the method with a nullptr, due to this assert:

Constant *ConstantExpr::getGetElementPtr(Type *Ty, Constant *C,
                                         ArrayRef<Value *> Idxs, bool InBounds,
                                         std::optional<unsigned> InRangeIndex,
                                         Type *OnlyIfReducedTy) {
  PointerType *OrigPtrTy = cast<PointerType>(C->getType()->getScalarType());
  assert(Ty && "Must specify element type");

Also I found it was an error specifying the index with [0,0], so here is my solution:

Value *Ptr = Builder.CreateInBoundsGEP(Str->getType(), Str, {Int32Zero}, "ptr");

[Fare9]

It looks like it was deprecated in LLVM 13:

https://github.com/llvm/llvm-project/blob/release/13.x/llvm/include/llvm/IR/IRBuilder.h#L1809-L1816

But there's also a solution in the deprecation code.

[amlloc]

It looks like it was deprecated in LLVM 13:

https://github.com/llvm/llvm-project/blob/release/13.x/llvm/include/llvm/IR/IRBuilder.h#L1809-L1816

But there's also a solution in the deprecation code.

thx, it's perfect!