Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(WIP) #120: Subscribe modal #166

Closed
wants to merge 5 commits into from
Closed

(WIP) #120: Subscribe modal #166

wants to merge 5 commits into from

Conversation

rpeterman-gp
Copy link
Contributor

Closes #120

  • Adds subscribe modal (PodLove) to app header nav.
  • Fixes parsing of referrerpolicy menu item attribute so it is applied to react anchor camelcased.
  • Fixes theme override of newsletter CTA form labels.
  • Various prettier formatting changes.

To Review

  • Use the Preview link located in the Now comment below.

...or...

  • Checkout Branch.
  • Run yarn.
  • Run yarn dev:start.
  • Go to localhost:3000.

...then...

  • Ensure subscribe button is shown in header nav.
  • Evaluate subscribe modal functionality.
  • Ensure console doesn't show any errors when applying referrerPolicy attribute to donate link in footer.
  • Ensure console doesn't show any warning in regard to them over ride of outlined inputs.

@rpeterman-gp rpeterman-gp requested a review from brandonhundt May 20, 2021 17:36
@rpeterman-gp rpeterman-gp self-assigned this May 20, 2021
@vercel
Copy link

vercel bot commented May 20, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/prx-tech/theworld.org/4hTR76zKvJyqkQQvaQSLkj5Xjc57
✅ Preview: https://theworldorg-git-feat-120-subscribe-modal-prx-tech.vercel.app

@rpeterman-gp rpeterman-gp changed the title #120: Subscribe modal (WIP) #120: Subscribe modal May 21, 2021
@rpeterman-gp rpeterman-gp mentioned this pull request Jun 4, 2021
Merged
8 tasks
@rpeterman-gp
Copy link
Contributor Author

Closing due to fundamental rethink of how feed subscription links are generated. PodLove button did meet needs, though code base is a good reference for service selection based on device in use.

rpeterman-gp added a commit that referenced this pull request Jun 7, 2021
@rpeterman-gp
Merge pull request #179 from PRX/fix/hotfix-referrerpolicy-newsletter…
ccbe43a 
…css-editorconfig

HOTFIX: Apply bug fixes from #166 PR
@rpeterman-gp rpeterman-gp deleted the feat/120-subscribe-modal branch November 3, 2021 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brandonhundt brandonhundt Awaiting requested review from brandonhundt

Assignees

@rpeterman-gp rpeterman-gp

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Subscribe Modal
1 participant
@rpeterman-gp