Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Retry asset wait file processing timeouts #1150

Open
wants to merge 18 commits into
base: main
Choose a base branch
from
Open

Retry asset wait file processing timeouts #1150

wants to merge 18 commits into from

Conversation

svevang
Copy link
Member

@svevang svevang commented Nov 5, 2024

Fixes #1138

This works towards some state handling changes based on #901

  1. prevent state oscillations around uploads. Depending on the exact set of circumstances, this could include duplicate media upload cycles and skipping polling for remote asset states
  2. This breaks up the main publishing routine and adds test coverage for that routine. So now there are two phases. First a media upload step and then the processing and delivery/publishing.

@svevang svevang marked this pull request as ready for review November 18, 2024 19:37
kookster
kookster approved these changes Dec 5, 2024
View reviewed changes
Copy link
Member

@kookster kookster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, I merged this into the megaphone pr, and I've been looking at it for awhile!
Makes sense, good to split up upload and delivery, and how those states are treated.

@kookster
Copy link
Member

fwiw - I have merged this branch into the megaphone branch/PR, so this will be deployed at the same time if megaphone pr gets merged
9b5aff3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kookster kookster kookster approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Delegated Delivery file processing timeouts causes 409s
2 participants
@svevang @kookster