Skip to content

Inconsistent line ending #2

@xandrd

Description

@xandrd

The codebase currently has inconsistent line ending across the files:

Files with LF only (43 files)

  • .gitattributes (1 lines)
  • .gitignore (13 lines)
  • .gitmodules (11 lines)
  • CMakeLists.txt (206 lines)
  • docs/Doxyfile (2388 lines)
  • docs/README.md (9 lines)
  • install_openblas.sh (29 lines)
  • install_openblas_ninja.ps1 (40 lines)
  • install_openblas_vs.ps1 (35 lines)
  • install_verb.ps1 (11 lines)
  • install_verb.sh (15 lines)
  • LICENSES/BSD-3-Clause.txt (11 lines)
  • README.md (227 lines)
  • src/BoundaryConditionType.hpp (173 lines)
  • src/Convection_1D_2ndORDER_NONUNIFORM_GRID.cpp (517 lines)
  • src/Convection_1D_2ndORDER_NONUNIFORM_GRID.h (55 lines)
  • src/Convection_1D_ULTIMATE_QUICKEST6.cpp (485 lines)
  • src/Convection_1D_ULTIMATE_QUICKEST6.h (81 lines)
  • src/CustomDate.cpp (163 lines)
  • src/CustomDate.h (90 lines)
  • src/DataAssimilation.cpp (374 lines)
  • src/DataAssimilation.h (223 lines)
  • src/DataAssimilationHelper.cpp (548 lines)
  • src/DataAssimilationHelper.h (192 lines)
  • src/Diffusion_2D_MKL.cpp (344 lines)
  • src/Diffusion_2D_MKL.hpp (36 lines)
  • src/Interpolation.cpp (51 lines)
  • src/Interpolation.h (28 lines)
  • src/MatrixOperations.cpp (803 lines)
  • src/MatrixOperations.h (353 lines)
  • src/MonotCubicInterpolator.cpp (725 lines)
  • src/MonotCubicInterpolator.hpp (592 lines)
  • src/Parameters.cpp (323 lines)
  • src/Parameters.h (164 lines)
  • src/PMF.cpp (828 lines)
  • src/PMF.h (165 lines)
  • src/python_bindings/const_reference_wrapper.h (15 lines)
  • src/python_bindings/Define_python_modules.cpp (24 lines)
  • src/python_bindings/Matrix_conversion.h (95 lines)
  • src/ReadInitialData.cpp (591 lines)
  • src/ReadInitialData.h (79 lines)
  • src/UpdatableMatrix.cpp (1150 lines)
  • src/UpdatableMatrix.h (173 lines)

Files with CRLF only (21 files)

  • src/Convection_2D.cpp (169 lines)
  • src/Convection_2D.h (110 lines)
  • src/Convection_3D.cpp (191 lines)
  • src/Convection_3D.h (124 lines)
  • src/Diffusion_1D.cpp (144 lines)
  • src/Diffusion_1D.h (79 lines)
  • src/Diffusion_2D.cpp (153 lines)
  • src/Diffusion_2D.h (114 lines)
  • src/Diffusion_ADI1.cpp (584 lines)
  • src/Diffusion_ADI1.h (177 lines)
  • src/Diffusion_ADI2.cpp (764 lines)
  • src/Diffusion_ADI2.h (101 lines)
  • src/Diffusion_ADI3.cpp (632 lines)
  • src/Diffusion_ADI3.h (100 lines)
  • src/Logger.cpp (245 lines)
  • src/Logger.h (138 lines)
  • src/Matrix.cpp (6577 lines)
  • src/Matrix.h (588 lines)
  • src/MatrixSolver.cpp (720 lines)
  • src/MatrixSolver.h (251 lines)
  • src/VERB4D_Solver.cpp (1290 lines)

Summary

  • Total LF line endings: 30109
  • Total CRLF line endings: 13266
  • Files with LF only: 43
  • Files with CRLF only: 21

Notes

  • LF (Line Feed, \n): Unix/Linux/macOS line ending
  • CRLF (Carriage Return + Line Feed, \r\n): Windows line ending

Suggestion

  • Change CRLF to LF (Linux compatible)
  • Define development rule
  • Forbid commits with CRLF line endings.
  • git can --renormalize repo fixing the existing line endings

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions