Skip to content

Commit a5e40c1

Browse files
pylapppylapp
committed
chore: remove dead code and update periphery notes
Signed-off-by: Pierre-Yves Lapersonne <[email protected]>
1 parent da0b9af commit a5e40c1

28 files changed

+36
-53
lines changed

‎.github/DEVELOP.md‎

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -615,7 +615,15 @@ bundle exec fastlane check_dead_code
615615
You can also in Xcode run from the *Periphery* scheme so as to make a scan.
616616

617617
> [!CAUTION]
618-
> Use a real device and not a simulator. In addition, do not use local reference of OUDS iOS Swift Package as many false-positive warnings can rise; us branch version instead.
618+
> Use a real device and not a simulator.
619+
620+
> [!CAUTION]
621+
> In addition, do not use local reference of OUDS iOS Swift Package as many false-positive warnings can rise; use branch version instead.
622+
623+
> [!TIP]
624+
> periphery is not perfect, and false positive can occur.
625+
> If so, create or update an isue in their repository and leave a note in the false-psotive line.
626+
> That is the reason why periphery-related jobs are allowed to fail, because of these false warnings.
619627
620628
## Software Bill of Materials
621629

‎DesignToolbox/DesignToolbox.xcodeproj/project.pbxproj‎

Lines changed: 18 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -49,12 +49,12 @@
4949
0745C1932D7A0596006B3A1F /* RadioElement.swift in Sources */ = {isa = PBXBuildFile; fileRef = 0745C18C2D7A0596006B3A1F /* RadioElement.swift */; };
5050
0745C1992D7A0823006B3A1F /* RadioItemPage.swift in Sources */ = {isa = PBXBuildFile; fileRef = 0745C1942D7A0823006B3A1F /* RadioItemPage.swift */; };
5151
0745C19C2D7A0823006B3A1F /* RadioItemPage.swift in Sources */ = {isa = PBXBuildFile; fileRef = 0745C1942D7A0823006B3A1F /* RadioItemPage.swift */; };
52-
075045F92E58717F00D98587 /* TetxInputPage.swift in Sources */ = {isa = PBXBuildFile; fileRef = 075045F82E58717F00D98587 /* TetxInputPage.swift */; };
53-
075045FA2E58717F00D98587 /* TetxInputElement.swift in Sources */ = {isa = PBXBuildFile; fileRef = 075045F72E58717F00D98587 /* TetxInputElement.swift */; };
54-
075045FB2E58717F00D98587 /* TetxInputConfigurationView.swift in Sources */ = {isa = PBXBuildFile; fileRef = 075045F62E58717F00D98587 /* TetxInputConfigurationView.swift */; };
55-
075045FC2E58717F00D98587 /* TetxInputPage.swift in Sources */ = {isa = PBXBuildFile; fileRef = 075045F82E58717F00D98587 /* TetxInputPage.swift */; };
56-
075045FD2E58717F00D98587 /* TetxInputElement.swift in Sources */ = {isa = PBXBuildFile; fileRef = 075045F72E58717F00D98587 /* TetxInputElement.swift */; };
57-
075045FE2E58717F00D98587 /* TetxInputConfigurationView.swift in Sources */ = {isa = PBXBuildFile; fileRef = 075045F62E58717F00D98587 /* TetxInputConfigurationView.swift */; };
52+
075045F92E58717F00D98587 /* TextInputPage.swift in Sources */ = {isa = PBXBuildFile; fileRef = 075045F82E58717F00D98587 /* TextInputPage.swift */; };
53+
075045FA2E58717F00D98587 /* TextInputElement.swift in Sources */ = {isa = PBXBuildFile; fileRef = 075045F72E58717F00D98587 /* TextInputElement.swift */; };
54+
075045FB2E58717F00D98587 /* TextInputConfigurationView.swift in Sources */ = {isa = PBXBuildFile; fileRef = 075045F62E58717F00D98587 /* TextInputConfigurationView.swift */; };
55+
075045FC2E58717F00D98587 /* TextInputPage.swift in Sources */ = {isa = PBXBuildFile; fileRef = 075045F82E58717F00D98587 /* TextInputPage.swift */; };
56+
075045FD2E58717F00D98587 /* TextInputElement.swift in Sources */ = {isa = PBXBuildFile; fileRef = 075045F72E58717F00D98587 /* TextInputElement.swift */; };
57+
075045FE2E58717F00D98587 /* TextInputConfigurationView.swift in Sources */ = {isa = PBXBuildFile; fileRef = 075045F62E58717F00D98587 /* TextInputConfigurationView.swift */; };
5858
075114DB2CB7D28D00B8B759 /* SizeTokenElement.swift in Sources */ = {isa = PBXBuildFile; fileRef = 075114D82CB7D28D00B8B759 /* SizeTokenElement.swift */; };
5959
075114DC2CB7D28D00B8B759 /* SizeTokenPage.swift in Sources */ = {isa = PBXBuildFile; fileRef = 075114D92CB7D28D00B8B759 /* SizeTokenPage.swift */; };
6060
075114E02CB7FDC200B8B759 /* ColorTokenElement.swift in Sources */ = {isa = PBXBuildFile; fileRef = 075114DE2CB7FDC200B8B759 /* ColorTokenElement.swift */; };
@@ -502,9 +502,9 @@
502502
0745C18C2D7A0596006B3A1F /* RadioElement.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = RadioElement.swift; sourceTree = "<group>"; };
503503
0745C18D2D7A0596006B3A1F /* RadioPage.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = RadioPage.swift; sourceTree = "<group>"; };
504504
0745C1942D7A0823006B3A1F /* RadioItemPage.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = RadioItemPage.swift; sourceTree = "<group>"; };
505-
075045F62E58717F00D98587 /* TetxInputConfigurationView.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = TetxInputConfigurationView.swift; sourceTree = "<group>"; };
506-
075045F72E58717F00D98587 /* TetxInputElement.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = TetxInputElement.swift; sourceTree = "<group>"; };
507-
075045F82E58717F00D98587 /* TetxInputPage.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = TetxInputPage.swift; sourceTree = "<group>"; };
505+
075045F62E58717F00D98587 /* TextInputConfigurationView.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = TextInputConfigurationView.swift; sourceTree = "<group>"; };
506+
075045F72E58717F00D98587 /* TextInputElement.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = TextInputElement.swift; sourceTree = "<group>"; };
507+
075045F82E58717F00D98587 /* TextInputPage.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = TextInputPage.swift; sourceTree = "<group>"; };
508508
075114D82CB7D28D00B8B759 /* SizeTokenElement.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = SizeTokenElement.swift; sourceTree = "<group>"; };
509509
075114D92CB7D28D00B8B759 /* SizeTokenPage.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = SizeTokenPage.swift; sourceTree = "<group>"; };
510510
075114DE2CB7FDC200B8B759 /* ColorTokenElement.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = ColorTokenElement.swift; sourceTree = "<group>"; };
@@ -945,9 +945,9 @@
945945
075045F52E58715D00D98587 /* TextInput */ = {
946946
isa = PBXGroup;
947947
children = (
948-
075045F62E58717F00D98587 /* TetxInputConfigurationView.swift */,
949-
075045F72E58717F00D98587 /* TetxInputElement.swift */,
950-
075045F82E58717F00D98587 /* TetxInputPage.swift */,
948+
075045F62E58717F00D98587 /* TextInputConfigurationView.swift */,
949+
075045F72E58717F00D98587 /* TextInputElement.swift */,
950+
075045F82E58717F00D98587 /* TextInputPage.swift */,
951951
);
952952
path = TextInput;
953953
sourceTree = "<group>";
@@ -2552,9 +2552,9 @@
25522552
072BB4562E69704C00A4DF2D /* SoshTheme+TextInputUITests.swift in Sources */,
25532553
07CC9AEE2DB0F7DD001BC929 /* SwitchElements.swift in Sources */,
25542554
07CC9AEF2DB0F7DD001BC929 /* SwitchItemElement.swift in Sources */,
2555-
075045FC2E58717F00D98587 /* TetxInputPage.swift in Sources */,
2556-
075045FD2E58717F00D98587 /* TetxInputElement.swift in Sources */,
2557-
075045FE2E58717F00D98587 /* TetxInputConfigurationView.swift in Sources */,
2555+
075045FC2E58717F00D98587 /* TextInputPage.swift in Sources */,
2556+
075045FD2E58717F00D98587 /* TextInputElement.swift in Sources */,
2557+
075045FE2E58717F00D98587 /* TextInputConfigurationView.swift in Sources */,
25582558
07CC9AF02DB0F7DD001BC929 /* SwitchPage.swift in Sources */,
25592559
07CC9AF22DB0F7DD001BC929 /* SwitchConfiguration.swift in Sources */,
25602560
51A2175D2E325ED500562BE0 /* OrangeBusinessToolsTheme+ButtonUITests.swift in Sources */,
@@ -2783,9 +2783,9 @@
27832783
07CF42892CA55BC8000BD03E /* ThemeSelection.swift in Sources */,
27842784
07CF427F2CA41325000BD03E /* OpacityTokenElement.swift in Sources */,
27852785
07CF426B2CA30728000BD03E /* TokensPage.swift in Sources */,
2786-
075045F92E58717F00D98587 /* TetxInputPage.swift in Sources */,
2787-
075045FA2E58717F00D98587 /* TetxInputElement.swift in Sources */,
2788-
075045FB2E58717F00D98587 /* TetxInputConfigurationView.swift in Sources */,
2786+
075045F92E58717F00D98587 /* TextInputPage.swift in Sources */,
2787+
075045FA2E58717F00D98587 /* TextInputElement.swift in Sources */,
2788+
075045FB2E58717F00D98587 /* TextInputConfigurationView.swift in Sources */,
27892789
07F75A372CC644C80004F1AD /* NamedSpace+Scaled.swift in Sources */,
27902790
0765B4A62CC15C9D00E69359 /* NamedColor.swift in Sources */,
27912791
07CC9AF42DB0F7DD001BC929 /* SwitchElement.swift in Sources */,

‎DesignToolbox/DesignToolbox.xcworkspace/xcshareddata/swiftpm/Package.resolved‎

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎DesignToolbox/DesignToolbox/MainView.swift‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@
1212
//
1313

1414
import OUDS
15-
import OUDSThemesOrange
1615
import SwiftUI
1716

1817
struct MainView: View {

‎DesignToolbox/DesignToolbox/Pages/About/AboutPage.swift‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
//
1313

1414
import OUDS
15-
import OUDSFoundations // NOTE: Seen as "unused" for Periphery (https://github.com/peripheryapp/periphery/issues/942)
15+
import OUDSFoundations
1616
import SwiftUI
1717

1818
struct AboutPage: View {

‎DesignToolbox/DesignToolbox/Pages/About/AccessibilityStatement/AccessibilityStatementPage.swift‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
//
1313

1414
import DeclarationAccessibility
15-
import OUDSFoundations // NOTE: Seen as "unused" for Periphery (https://github.com/peripheryapp/periphery/issues/942)
15+
import OUDSFoundations
1616
import SwiftUI
1717

1818
struct AccessibilityStatementPage: View {

‎DesignToolbox/DesignToolbox/Pages/Components/Controls/Checkbox/CheckboxPicker/CheckboxPickerElement.swift‎

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -11,9 +11,6 @@
1111
// Software description: A SwiftUI components library with code examples for Orange Unified Design System
1212
//
1313

14-
import OUDS
15-
import OUDSComponents
16-
import OUDSThemesOrange
1714
import SwiftUI
1815

1916
struct CheckboxPickerElement: DesignToolboxElement {

‎DesignToolbox/DesignToolbox/Pages/Components/Controls/Chip/Picker/ChipPickerPage.swift‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -40,8 +40,6 @@ struct ChipPickerDemo: View {
4040

4141
@StateObject var configurationModel: ChipPickerConfigurationModel
4242

43-
@Environment(\.theme) private var theme
44-
4543
var body: some View {
4644
switch configurationModel.selectionType {
4745
case .singleOrNone:

‎DesignToolbox/DesignToolbox/Pages/Components/Controls/Radio/Radio/RadioElement.swift‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@
1212
//
1313

1414
import OUDS
15-
import OUDSComponents
1615
import SwiftUI
1716

1817
struct RadioElement: DesignToolboxElement {

‎DesignToolbox/DesignToolbox/Pages/Components/Controls/Radio/RadioElements.swift‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,6 @@
1313

1414
import OUDS
1515
import OUDSComponents
16-
import OUDSThemesOrange
1716
import SwiftUI
1817

1918
struct RadioElements: DesignToolboxElement {

0 commit comments

Comments
 (0)