Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Double-check that focus visible is well applied on all components and modules #1785

Open
Tracked by #1761
hannahiss opened this issue Jan 17, 2023 · 1 comment
Open
Tracked by #1761
Assignees
Labels
docs Improvements or additions to documentation v5

Comments

@hannahiss
Copy link
Member

No description provided.

@louismaximepiton louismaximepiton added v5 docs Improvements or additions to documentation labels Jan 17, 2023
@louismaximepiton louismaximepiton self-assigned this Feb 13, 2023
@louismaximepiton
Copy link
Member

Quick summary

The focus state changed the day before the release of the UI kit v5. So the artboards we have might miss some things or might be not up to date. For example the 2px box-shadow isn't represented on design specs.

Issues encountered

Accordion

Should be able to see the border at all time but the box-shadow hide it on focus. anything to do here ?
image

Instead of:
image

Back to top

If I remember well the design changed since it wasn't possible to have the outline around the text.
image

Instead of:
image

Forms

Due to a technical issue, they look the same as before since we can't differenciate the focus from keyboard and the focus on mouse for text inputs.

List group

Due to technical implementation from Bootstrap. Maybe we can try to modify this on their side ? Maybe tweak a bit the design to allow focus on border right and left ?
image

Could be this:
image

Instead of:
image

Navbars

Should be tackled by #1691. We don't have specs for the minimized header but we can assume that the spacing is the same.
image

Instead of:
image

Remaining

The remaining components don't have any excuses to don't follow the design.

@louismaximepiton louismaximepiton removed their assignment Feb 13, 2023
@hannahiss hannahiss self-assigned this Mar 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to documentation v5
Projects
None yet
Development

No branches or pull requests

2 participants