Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add color scaledown modes #58

Open
asiekierka opened this issue Jan 3, 2025 · 0 comments
Open

Add color scaledown modes #58

asiekierka opened this issue Jan 3, 2025 · 0 comments

Comments

@asiekierka
Copy link
Contributor

From H-A-M-G-E-R:

And make it optional: provide several options:
simple right-shift, this, and multiplying by 31 then dividing by 256, rounded, floored or ceilinged

In particular, not having simple right-shift effectively causes a compatibility regression, and also some unintuitive behaviour (for example, on WonderSwan, the color #999999 now rounds up to #AAA, where most would expect it to stay at #999 as that's how emulators render it too).

I think "simple right-shift" (floor), "simple rounding" (round) and "multiplying by ((1 << shift) - 1) then dividing by 255" (scale) would be sufficient, with floor as the default to keep backwards compatibility.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant