Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNES color conversion #50

Open
H-A-M-G-E-R opened this issue May 10, 2024 · 2 comments
Open

SNES color conversion #50

H-A-M-G-E-R opened this issue May 10, 2024 · 2 comments

Comments

@H-A-M-G-E-R
Copy link

why is it taking a color and dividing each component by 8 and flooring instead of multiplying each component by 31/255 and then rounding?
@lintbe
Copy link
Contributor

lintbe commented Jun 18, 2024

I just went to the same conclusion last night while trying to figure out why the colors on my converted image was so far from orginal. After reading the source code, I went to the same conclusion. I will try to make a patch for this.

@lintbe lintbe mentioned this issue Jun 18, 2024
Closed
@asiekierka
Copy link
Contributor

#55 Providing a more generalized patch here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@asiekierka @lintbe @H-A-M-G-E-R