You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In the code here: https://github.com/Optiroc/SuperFamiconv/blob/master/src/Palette.cpp#L93,
this check seems wrong when using 2 BPP or more that 1 palette. If the check fails, SuperFamiconv throws an exception and enters the catch block and tries to read the json palette as a binary palette with pretty random results.
In my case, I have a 16 colors palette in the original image that I expect SuperFamiconv to convert to 4 palettes with 4 colors each in 2 bpp mode. The check fails because 16 colors is greater than 4.
Using native binary palettes instead seems to work ok.
The text was updated successfully, but these errors were encountered:
In the code here: https://github.com/Optiroc/SuperFamiconv/blob/master/src/Palette.cpp#L93,
this check seems wrong when using 2 BPP or more that 1 palette. If the check fails, SuperFamiconv throws an exception and enters the catch block and tries to read the json palette as a binary palette with pretty random results.
In my case, I have a 16 colors palette in the original image that I expect SuperFamiconv to convert to 4 palettes with 4 colors each in 2 bpp mode. The check fails because 16 colors is greater than 4.
Using native binary palettes instead seems to work ok.
The text was updated successfully, but these errors were encountered: