Conversation
CI's matrix moves from 1.11/1.12 to 1.12/1.13 and the tracked default manifest resolved under 1.11 is replaced by one resolved under 1.13. bin/install, bin/create_sys_image and bin/update_default_manifest offer and accept the same pair, and no longer move the machine-wide juliaup default: they export JULIAUP_CHANNEL for their own run instead. Unit `kitecontrollers` of plans/julia-1-13.md, 1-Bart-1/Agents#282. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014iySjM4uf9zc95zhvzTzCo
The root one was tracked-visible while examples/ was ignored; every sibling repo in the fleet ignores it unqualified. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01GHQftAA8Y698UFeyRNcy7F
Member
Author
|
Local full suite: PASS (3 min, Julia 1.12.7, one cell of the matrix) |
Member
Author
|
Closing: Bart has taken this repo out of the Julia 1.13 plan (1-Bart-1/Agents#282) because @ufechner7 moves it to 1.13 himself. The branch stays in case any of it is useful. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR
KiteControllers.jl tests Julia 1.12 and 1.13 instead of 1.11 and 1.12, and tracks a default manifest resolved under 1.13 in place of the one resolved under 1.11. The
bin/scripts move with it and stop setting the machine-widejuliaup default, whichAGENTS.md§2 says no repo script may do.What this repo had, of the shared procedure
All five steps, and the scripts were the bulk of it.
Matrix.
CI.ymlnamed'1.11'and'1.12';Docs.ymlis on'1'and stays. The cache step carriedif: runner.os != 'Windows' || matrix.version != '1.11'— a workaround for one cell that no longer exists, so with the new matrix the condition is true everywhere and the line is gone.Compat.
julia = "1.11, 1.12"in the rootProject.tomland the same entry indocs/Project.toml, both now"1.11, 1.12, 1.13"— the same range, with 1.13 named. Three more entries enumerate the same Julia minors and moved with them:PkgandPrintfin the root,Testintest/Project.toml. Those three were not required for the resolve, and I checked rather than assumed: a throwaway project pinningPkg = "1.10, 1.11, 1.12"still resolvesPkg v1.13.0under Julia 1.13, because Pkg does not apply compat bounds to bundled stdlibs. They are in the diff only so the lines do not read as stale.Manifests. The minimal resolve of
AGENTS.md§2, seeded fromManifest-v1.12.toml.defaultin a session on 1.13, moved stdlibs and JLLs and nothing else —Pkg 1.12.1 → 1.13.0,SHA,LibCURL,SparseArrays,LinearAlgebra,CompilerSupportLibraries_jll,MozillaCACerts_jlland friends — withproject_hashunchanged. Most of the manifest's +822/−285 is not that:manifest_formatgoes 2.0 → 2.1, which writes aregistries = "General"line under every dependency.Scripts.
bin/installloses 51 lines. Its interactive selector offers 1.12 and 1.13; the whole Julia-1.11 arm of the sub-project instantiation is gone; and the per-version manifest copy collapses toManifest-v${julia_major}.toml.defaultnow that both supported minors have a tracked default.bin/create_sys_imagereplaced itsjuliaup add/juliaup default 1.11fallback with the same refusalbin/installgives.bin/update_default_manifestlost its 1.10 and 1.11 branches the same way.bin/autopilotpicked thread flags per minor — 1.13 gets-t 1,0, the 1.12 spelling, rather than falling through to the default..github/copilot-instructions.mdnamed the two versions and the two manifests;.gitignoreneeded the 1.13 live manifest and install stamp.One find rode along in
.gitignore, since the diff had it open anyway: it ignoredexamples/LocalPreferences.tomlbut not the root one, which Julia writes whenever a preference is set. KiteUtils.jl, KiteModels.jl, SymbolicAWEModels.jl and VortexStepMethod.jl all ignore it unqualified, so this one now does too, and theexamples/line is redundant and gone.Where a script used to run
juliaup defaultit now exportsJULIAUP_CHANNELfor its own process, which selects the channel without touching the box.What went with the 1.11 arm, and what did not
The deleted 1.11 arm of
bin/installcarried a Linux-only check that warned whenMakieControlPlotsfailed to load; the 1.12 arm never had it. It is not replaced, because the surviving path ends injulia --project=examples -e 'using KiteControllers, KiteViewers, MakieControlPlots, NOMAD', which fails the install outright rather than warning.Where I would push back
CI.ymlstill carriesfail-fast: false, which the gate calls acleanup:PR of its own — the plan says explicitly not to fold it in here, so I did not.Two things in
bin/installare the same class of rule-break as thejuliaup defaultthis PR removes, and are not this PR's idea: it appendsalias jl='bin/run_julia'to~/.bashrc, and itPkg.adds Revise into the shared global environment. Both areAGENTS.md§2 "nothing outside the repo". Worth a follow-up.The docs build warns that
KiteControllers.get_depoweris in no manual page.warnonly = trueindocs/make.jlkeeps the build green, so the gate's "make.jl errors on undocumented exports" does not bite here. Pre-existing, not touched.Verification
test/runtests.jlunder Julia 1.13.0, in the worktree's juliaserver session:Testing KiteControllers... | 232 Pass | 232 Total | 37.8susing KiteControllersin 2.1 s.test/instantiates (130 deps precompiled, KiteViewers and MakieControlPlots included).CI.ymlandDocs.ymltrigger onpull_request, not on a branch push, so the push alone produced no runbin/reuse_lintif:was a Windows-only exclusion; if the 1.13 Windows cell is slow or flaky on the cache, that line is where to look.Scope
+902 / −429 across 12 files, of which
Manifest-v1.11.toml.default → Manifest-v1.13.toml.defaultis +822 / −285 and mostly the 2.0 → 2.1 format change. The hand-written part is +80 / −144 across 11 files. Unitkitecontrollersofplans/julia-1-13.md, 1-Bart-1/Agents#282; no stack — nothing open touches these files.Closes #67 · task
KiteControllers.jl-67