Skip to content

Commit 1338c79

Browse files
Revise vehicle type description
- Add note on compliance with ASAM TrafficParticipants Specification - Adapt note on OSI's obsolete type mapping issue (switch to past tense, revise wording) - Remove obsolete note on difficult distinction between OSI's vehicle types Signed-off-by: Thomas Sedlmayer <[email protected]>
1 parent 60af20e commit 1338c79

File tree

2 files changed

+25
-17
lines changed

2 files changed

+25
-17
lines changed

.github/spelling_custom_words_en_US.txt

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -83,6 +83,7 @@ dms
8383
doi
8484
doppler
8585
drivable
86+
DSL
8687
dt
8788
Duesseldorf
8889
Durchgangsverkehr
@@ -175,6 +176,7 @@ illuminance
175176
ilv
176177
im
177178
Immission
179+
implementer's
178180
incrementing
179181
Industriegebiet
180182
innerhalb

osi_object.proto

Lines changed: 23 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -760,23 +760,29 @@ message MovingObject
760760
{
761761
// Definition of vehicle types.
762762
//
763-
// \note OSI provides a richer set of vehicle types than is supported by some
764-
// other OpenX standards (in particular, OpenScenario 1.x and 2.x, and OpenLabel).
765-
// This is primarily for historical reasons. Where a single type from a
766-
// different standard can map to multiple OSI types it is left up to the
767-
// discretion of the OSI implementer how that mapping is achieved. In previous
768-
// versions, for example, a simulator might have used the dimensions of a provided
769-
// 3d model of a vehicle with type "car" in OpenScenario, to determine whether it
770-
// should be a TYPE_SMALL_CAR or TYPE_MEDIUM_CAR in OSI. As part of the harmonization
771-
// effort, it should now map to TYPE_CAR, which is an alias of the old TYPE_MEDIUM_CAR,
772-
// and all other car type enums have been deprecated in favor of TYPE_CAR.
773-
//
774-
// \note Vehicle type classification is a complex area and there are no
775-
// universally recognized standards. As such, the boundaries between some of the
776-
// OSI vehicle types are not well-defined. It is left to the implementer to
777-
// decide how to distinguish between them and agree that with any applications which
778-
// make use of that specific interface instance. For example, how to distinguish
779-
// between a HEAVY_TRUCK and a DELIVERY_VAN, or a TRAILER and a SEMITRAILER.
763+
// \note OSI defines a set of vehicle types derived directly from the
764+
// vehicle main categories specified in the ASAM TrafficParticipants
765+
// Specification [1]. The type names and definitions reflect an effort
766+
// toward compatibility with multiple ASAM OpenX standards, to support
767+
// consistent cross-standard mapping. As part of ongoing and future
768+
// harmonization efforts, OSI will continue to keep its vehicle type
769+
// definitions synchronized with the ASAM TrafficParticipants
770+
// Specification as permitted by technical and practical constraints.
771+
//
772+
// \note Historically, OSI offered a more granular set of vehicle types
773+
// than some other OpenX standards (e.g., OpenScenario XML/DSL and
774+
// OpenLabel). This was due to legacy design choices. Mapping a single
775+
// type from another standard to multiple OSI types was left to the
776+
// implementer's discretion. For instance, a simulator might have relied
777+
// on the 3D model's dimensions for an OpenScenario "car" to choose
778+
// between TYPE_SMALL_CAR or TYPE_MEDIUM_CAR in OSI. With the ongoing
779+
// harmonization effort, such ambiguities have been resolved. The
780+
// recommended mapping is now TYPE_CAR, which serves as an alias for the
781+
// former TYPE_MEDIUM_CAR. Previous car-specific enums (e.g.,
782+
// TYPE_SMALL_CAR) have been deprecated in favor of TYPE_CAR.
783+
//
784+
// \par References:
785+
// [1] ASAM e.V. (2024). <em>ASAM TrafficParticipants Specification</em>. ASAM OpenX Standards. Retrieved June 12, 2025, from https://publications.pages.asam.net/standards/ASAM_TrafficParticipants_Specification/ASAM_TrafficParticipants_Specification/v1.0.0/specification/index.html
780786
//
781787
enum Type
782788
{

0 commit comments

Comments
 (0)