Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lmr: front: catch missing fields and adapt warning message #9707

Open
1 task
axrolld opened this issue Nov 14, 2024 · 4 comments · May be fixed by #10271
Open
1 task

lmr: front: catch missing fields and adapt warning message #9707

axrolld opened this issue Nov 14, 2024 · 4 comments · May be fixed by #10271
Assignees
Labels
area:front Work on Standard OSRD Interface modules kind:enhancement Improvement of existing features module:stdcm Short-Term DCM

Comments

@axrolld
Copy link
Contributor

axrolld commented Nov 14, 2024

Description

Some fields can be left empty and the simulation button does nothing. We need to catch empty fields and warn the user.

AC

  • If one of the following fileds is not filled in, the warning box pops up above the button Obtenir la simulation when the user clicks it only (not before). The button Obtenir la simulation slides down, and if it gets out of the screen, there should be an automatic scroll to see the warning message entirely and the simulation button.
    • traction engine
    • consist total weight
    • consist total length
    • consist max speed
    • CI of origin/destination
    • departure or arrival time

Image

@axrolld axrolld added area:front Work on Standard OSRD Interface modules kind:enhancement Improvement of existing features module:stdcm Short-Term DCM labels Nov 14, 2024
@axrolld axrolld linked a pull request Nov 14, 2024 that will close this issue
4 tasks
@axrolld axrolld changed the title lmr: front: catch any missing/invalid fields and warn the user lmr: front: catch missing fields and adapt warning message Nov 14, 2024
@axrolld axrolld removed a link to a pull request Nov 14, 2024
4 tasks
@axrolld axrolld assigned Caracol3 and unassigned Wadjetz Nov 14, 2024
@thibautsailly
Copy link

I uploaded the mockup in the wrong issue, following a mislabelling in Sketch. Sorry for the misunderstanding and for the potential wasted time, I'll double check before posting from now on!
Deleting the uploaded mockup to prevent more confusion.

@axrolld
Copy link
Contributor Author

axrolld commented Jan 9, 2025

There's this bug currently : it's possible to run a simulation with plenty of wrong values. I guess closing this issue will solve this, isn't it @Caracol3 ?
Image

@Caracol3
Copy link
Contributor

Caracol3 commented Jan 9, 2025

It's not clearly stated in the issue, but I think it would be logical to prevent the calculation when there are invalid values, rather than just displaying an informative message.

@axrolld
Copy link
Contributor Author

axrolld commented Jan 9, 2025

Hm, you're right, the issue is actually just mentionning empty fileds. What do you think about blocking invalid ones too ? Should i open a new issue ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:front Work on Standard OSRD Interface modules kind:enhancement Improvement of existing features module:stdcm Short-Term DCM
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants