core: refacto combo box #779
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Here are the main changes: - the combo box takes now a value of type T and not a string anymore - the combo box has a default behavior (filters on the labels) but a custom behaviour can be used - the hook useOutsideClick replaces the previous handleParentDivBlur function - a new story has been added to test the custom behavior Signed-off-by: Clara Ni <[email protected]>
clarani
force-pushed
the
cni/778-refacto-combo-box
branch
from
0c50296 to
3ebcc5e
Compare
emersion
reviewed
Dec 23, 2024
| if (userInput.trim() === '') { | ||
| setFilteredSuggestions([]); | ||
| setSelectedOption(null); | ||
| const filterSuggestions = useCallback((input: string) => { |
There was a problem hiding this comment.
Can't we use useMemo() here instead of these useEffect() calls?
emersion
reviewed
Dec 23, 2024
| disableDefaultFilter?: boolean; | ||
| getSuggestionLabel: (option: T) => string; | ||
| onSelectSuggestion: (option: T | undefined) => void; | ||
| customOnInputChange?: (inputValue: string) => void; |
There was a problem hiding this comment.
This feels a bit awkward when there is already an onChange prop that users can set if they need to react to text input changes…
It seems like in OSRD we want to pre-filter suggestions before we pass them to the combobox?
Alternative proposals:
- A
filterSuggestions: booleanprop to enable/disable the combobox built-in filtering. - A
filterSuggestions: (suggestions: T[], query: string) => T[]prop to tweak the combobox built-in filtering. Can be set to(suggestions, query) => suggestionsto disable filtering. SupersedesexactSearch.
emersion
reviewed
Dec 23, 2024
| }); | ||
| setFilteredSuggestions(filtered); | ||
| }, []); | ||
|
|
||
| // behaviors |
There was a problem hiding this comment.
Nit: "behavior" is uncountable in this context
emersion
reviewed
Dec 23, 2024
clarani
force-pushed
the
cni/778-refacto-combo-box
branch
from
50eb6ab to
063a491
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #778
Here are the main changes: