Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set up RapiDoc #13

Open
keunes opened this issue Feb 24, 2023 · 8 comments
Open

Set up RapiDoc #13

keunes opened this issue Feb 24, 2023 · 8 comments
Assignees
Labels
Infrastructure Issues relating to tooling or setup

Comments

@keunes
Copy link
Member

keunes commented Feb 24, 2023

Use https://github.com/rapi-doc/RapiDoc to get something pretty like the Podcast Index API specs (code)

@georgkrause
Copy link
Collaborator

Whats the advantage of RapiDoc over Swagger in our scenario?

@georgkrause
Copy link
Collaborator

@keunes ping :)

@georgkrause georgkrause self-assigned this Mar 13, 2023
@georgkrause
Copy link
Collaborator

I will take care for this as soon as the task is clear. Plan is to use Github Actions and Pages.

@keunes
Copy link
Member Author

keunes commented Mar 13, 2023

@georgkrause Pong

Whats the advantage of RapiDoc over Swagger in our scenario?

I have no idea as I'm not familiar with Swagger and only know RapiDoc from the consumption side. Maybe @Sporiff has something to add here?

@Sporiff
Copy link
Member

Sporiff commented Mar 13, 2023

I have no idea as I'm not familiar with Swagger and only know RapiDoc from the consumption side. Maybe @Sporiff has something to add here?

@keunes Swagger UI, RapiDoc, and Redocly will all offer us much the same thing. Rapidoc takes significantly less initial setup since we can just throw an HTML page up and point it at a Yaml file, but none of them are particularly difficult.

The advantage of Swagger UI is we wouldn't be pulling JS from a CDN each time.

@Sporiff Sporiff added the Infrastructure Issues relating to tooling or setup label Mar 14, 2023
@georgkrause
Copy link
Collaborator

The advantage of Swagger UI is we wouldn't be pulling JS from a CDN each time.

@Sporiff Thats easy enough to avoid, though. But what is your argument against a CDN?

@Sporiff
Copy link
Member

Sporiff commented Mar 15, 2023

@georgkrause no particular argument, it's just another call. I don't consider it as much of an issue as lack of theming 😛

@Sporiff Sporiff assigned Sporiff and unassigned georgkrause Jan 28, 2024
@Sporiff Sporiff added this to the 🌟 Starlight migration milestone Jan 28, 2024
@keunes
Copy link
Member Author

keunes commented Nov 3, 2024

@Sporiff I guess we could close this one?

I do like the field-level explanations for the responses - we should add the descriptions in our Open API schema file - created #117.

I also think the Podcast Index API specs is a bit easier to process than our API explorer. It looks a bit cleaner thanks to:

  • the example & schema being separated by a switch (you don't see both at the same time)
  • the different pieces of info (name, type, description) of each field being a bit more compact and one one line/in one row
  • the nesting in a response (e.g. the individual subscriptions in our subscriptions endpoint) being expanded by default

Are these things we could configure, or could request support for from the Astro folks?

image

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Infrastructure Issues relating to tooling or setup
Projects
None yet
Development

No branches or pull requests

3 participants