Skip to content

Feature: Remove object tags #2354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dl3sdo opened this issue Mar 29, 2025 · 11 comments · May be fixed by #2355
Open

Feature: Remove object tags #2354

dl3sdo opened this issue Mar 29, 2025 · 11 comments · May be fixed by #2355

Comments

@dl3sdo
Copy link
Member

dl3sdo commented Mar 29, 2025

Add possibility to selectively remove object tags in order to reduce file size and memory consumption.
This feature was proposed by @krticka in #2341.

Implementation proposal:

RemoveTags.mp4

The proposed implementation follows Mapper's typical behaviour:

  • operate on selected objects (thus limit removing to current map part)
  • allow to undo the removal (since adding an undo step does not reduce file size and memory consumption, the option is not active by default)

If all object tags shall be removed the user needs to

  • switch to every map part
  • select all objects of that part
  • and remove all object tags by selecting a non-existent key (e.g., !) in combination with 'not equal to'
dl3sdo added a commit to dl3sdo/mapper that referenced this issue Mar 29, 2025
Add dialog to remove object tags from selected objects that match
a configurable pattern.
Allow to create an undo step.

Closes OpenOrienteeringGH-2354 (Remove objects tags).
@dl3sdo dl3sdo linked a pull request Mar 29, 2025 that will close this issue
@dl3sdo dl3sdo changed the title Feature: Remove objects tags Feature: Remove object tags Mar 29, 2025
@dl3sdo
Copy link
Member Author

dl3sdo commented Mar 29, 2025

@krticka: please test the current implementation, does it fulfill your needs?

@krticka
Copy link
Contributor

krticka commented Mar 29, 2025

@dl3sdo I can confirm that it works as intended. Well done!

dl3sdo added a commit to dl3sdo/mapper that referenced this issue Apr 6, 2025
Add dialog to remove object tags from selected objects that match
a configurable pattern.
Allow to create an undo step.

Closes OpenOrienteeringGH-2354 (Remove objects tags).
@dl3sdo
Copy link
Member Author

dl3sdo commented Apr 6, 2025

Idea for clustering all removal actions (see also #2289) in the edit menu without making it too extensive:

Cleanup_menu_idea.mp4

@jmacura
Copy link
Contributor

jmacura commented Apr 6, 2025

Idea for clustering all removal actions (see also #2289) in the edit menu without making it too extensive (...)

The "Cleanup" menu item reminds me the magical "optimize / repair" button from OCAD 🙂

@dl3sdo
Copy link
Member Author

dl3sdo commented May 9, 2025

I refactored the dialog to show the relevant information there instead of showing details in the confirmation popup.
The confirmation popup message is no longer a combination of two plural sensitive translations (thanks for the hint @dg0yt):

RemoveTagsRefactored.mp4

@krticka
Copy link
Contributor

krticka commented May 10, 2025

@dl3sdo I have tested, it works perfectly!

@dg0yt
Copy link
Member

dg0yt commented May 20, 2025

I suggest to place the action in the Map menu, e.g. as "Cleanup object tags...".

dl3sdo added a commit to dl3sdo/mapper that referenced this issue May 20, 2025
Add dialog to remove object tags from selected objects that match
a configurable pattern.
Allow to create an undo step.

Closes OpenOrienteeringGH-2354 (Remove objects tags).
@jmacura
Copy link
Contributor

jmacura commented May 21, 2025

I suggest to place the action in the Map menu, e.g. as "Cleanup object tags...".

That feels even more ocadish ("Map" -> "Optimize / repair"). I wonder if your suggestion was influenced (intentionally or subliminally) by its design.

@dl3sdo
Copy link
Member Author

dl3sdo commented May 21, 2025

Hi @jmacura, I can only talk for me but it's difficult to find a good place for that menu item. The initial location in the Tag editor was not really a good idea but just a starting point.
The Tools menu could be an option as the new tool operates on selected objects but this menu is already too overloaded (BTW: I think that Unify areas, Intersect areas, Cut away from area and Area XOr could be moved to a submenu).
Placing it in the Edit menu below the Find and Find next could be an option as these also operate on tags.

@dg0yt
Copy link
Member

dg0yt commented May 22, 2025

I wonder if your suggestion was influenced (intentionally or subliminally) by its design.

No. @dl3sdo explained it quite well. In addition, it is really a user-driven (maintenance) activity, not an opaque "optimization" or "repair" job.

@jmacura
Copy link
Contributor

jmacura commented May 22, 2025

Considering the explanation by @dl3sdo , I am hardly finding any relation to the other tools in the "Map" menu. Placing it below the "Find" and "Find next" options in the "Edit" menu feels more natural to me. But, just my 2c.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants