Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support broadcasting in binary operators #561

Open
guillaumekln opened this issue Sep 13, 2021 · 0 comments
Open

Support broadcasting in binary operators #561

guillaumekln opened this issue Sep 13, 2021 · 0 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@guillaumekln
Copy link
Collaborator

The binary operators:

  • ops::Add
  • ops::Mul
  • ops::Sub

currently do not support broadcasting. One should instead call the lower level primitives such as add_depth_broadcast which require device and type dispatch.

The operators should be updated to at least support broadcasting on the first dimension (batch) and the last dimension (depth).
@guillaumekln guillaumekln added enhancement New feature or request help wanted Extra attention is needed labels Sep 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@guillaumekln