Skip to content
This repository was archived by the owner on Dec 18, 2024. It is now read-only.

New index page. Two -A releases are listed, but not the later releases #83

Closed
jmudge opened this issue Jun 28, 2022 · 13 comments
Closed
Assignees

Comments

@jmudge
Copy link
Contributor

jmudge commented Jun 28, 2022

For the following enablers the Approved releases are listed in the new index page, but not the Candidate releases published after the Approved release:

  • OMA RESTful Network API for Anonymous Customer Reference Management - REST_NetAPI_ACR
  • OMA RESTful Network API for Customer Profile - REST_NetAPI_CustomerProfile

Any company using the listed release documents would not be using the latest published release.

Perhaps these Approved releases should be removed from the enablers.json file?

@jpradocueva
Copy link
Member

@jmudge we need to talk about these ones. The enabler was approved and then a new release appears as Candidate without any change in the version.

@jpradocueva
Copy link
Member

This it seems that it may only be resolved by having a flag.

@jpradocueva jpradocueva assigned rubystream and unassigned jpradocueva Jul 4, 2022
@jpradocueva
Copy link
Member

@rubystream we have identified an issue where the release was incorrectly named. At this stage, we cannot change for different reasons.
We wonder if it is possible to introduce a flag property. If the flag is set to e.g. true, then the enabler release is not displayed.
Will be possible to introduce such a functionality?
Will it imply a big change?

@rubystream
Copy link
Collaborator

@jpradocueva it's possible to have a property with any name that will be used for special processing. It should better have some less generic name. Something that will indicate the purpose.

@jpradocueva
Copy link
Member

@rubystream you are right. The flag name should be called display.

The criteria and behaviour for this flag should overrule any defined criteria, for instance:

If display: ¨True¨, then the content on the sub-folder should be displayed independent of any other criteria.
If display: ¨False¨, then the content on the sub-folder should NOT be displayed independent of any other criteria.

if display is not present, then the previous criteria apply.
Is this easy to implement?

@rubystream
Copy link
Collaborator

Yes, we can introduce this display flag that will have following meaning:

  • if not present the selection will be based on default business rules
  • if present with value True the item will be rendered regardless of the business rules
  • if present with value False then the item will not be rendered regardless of the business rules

This is not hard to implement it's a small addition to the current business rules.

@jpradocueva
Copy link
Member

@rubystream great!
If we introduce the above logic we can resolve issues that may require a logic against the current rules.
We have identified some corner cases where the release was incorrectly created and under the current rules won´t be possible to display.
Please feel free to create a PR on your own time to resolve the issue.
Thanks!

@rubystream
Copy link
Collaborator

The display attribute is implemented in 86bec7d revision.

@jpradocueva can you verify that is working as expected.

@rubystream rubystream assigned jpradocueva and unassigned rubystream Jul 21, 2022
@jpradocueva
Copy link
Member

@jmudge the new functionality has been added.
display is a new property, if it is set to true, then the Version is displayed despite any other criteria.
If set to false it is not displayed despite any other criteria.
cd80272

Please check, if this is ok with the pending issues. Thanks.

@jpradocueva jpradocueva assigned jmudge and rubystream and unassigned jpradocueva Jul 22, 2022
@jpradocueva
Copy link
Member

@rubystream, @jmudge the new display property works as expected when the value is set to true, but it doesn't seem to work when the value is set to false.

@rubystream
Copy link
Collaborator

@jpradocueva can you provide the example for the false use case? Perhaps I have tried the incorrect one.

@rubystream
Copy link
Collaborator

I have find the reason why the false was not working. :-)
The business logic for display attribute is working as expected. This attribute is expected a boolean value true or false not a string "true" or string "false". It was working for the string "true" as it's interpreted as true, the same as "false".

Ergo in JSON file the display attribute of the version in question should be boolean true or false not a string.

jmudge added a commit that referenced this issue Jul 25, 2022
@jmudge
Copy link
Contributor Author

jmudge commented Jul 25, 2022

Issue can be closed when #88 has been merged.

@jmudge jmudge closed this as completed Jul 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants