-
Notifications
You must be signed in to change notification settings - Fork 13
Add workflow_call support with image-registry-namespace parameter #116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
simonrosenberg
wants to merge
12
commits into
main
Choose a base branch
from
openhands/workflow-call-support
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add workflow_call trigger with inputs and outputs - Export images_built, sdk_commit, and image_base_name as outputs - Add sdk-info and build-summary steps to capture outputs - Support workflow_call event in conditional logic Co-authored-by: openhands <[email protected]>
08627c8 to
170e6b7
Compare
Co-authored-by: openhands <[email protected]>
This will help identify if the builder setup is failing silently when called via workflow_call from another repository. Co-authored-by: openhands <[email protected]>
When workflow is called via workflow_call from another repository, the token might need to be passed explicitly for the builder setup to access GitHub/Blacksmith APIs. Co-authored-by: openhands <[email protected]>
When workflow_call is used, Blacksmith incorrectly uses the calling repository's cache (software-agent-sdk) instead of the workflow's repository (benchmarks). The software-agent-sdk cache has a corrupted history.db that causes buildkitd to crash. Skip the integrity check as a workaround. Co-authored-by: openhands <[email protected]>
Override GITHUB_REPOSITORY and GITHUB_REPOSITORY_OWNER environment variables when workflow is called via workflow_call. This ensures Blacksmith and other tools use the benchmarks repository context instead of the calling repository. Co-authored-by: openhands <[email protected]>
Co-authored-by: openhands <[email protected]>
GitHub Actions passes the calling repo's context to reusable workflows, not 'workflow_call' as event_name. Detect workflow_call by checking if github.repository doesn't match expected repo. Co-authored-by: openhands <[email protected]>
When called via workflow_call, the sticky disk may contain database files from the calling repository context, causing corruption. Clear history.db and cache.db to start fresh. Co-authored-by: openhands <[email protected]>
Replace setup-docker-builder with manual Buildx setup using explicit stickydisk key 'swebench-buildkit-cache'. This ensures consistent cache regardless of caller repository when invoked via workflow_call, avoiding implicit context derivation issues. Co-authored-by: openhands <[email protected]>
Required for ghcr.io authentication when called via workflow_call. Co-authored-by: openhands <[email protected]>
|
Looks like there are a few issues preventing this PR from being merged!
If you'd like me to help, just leave a comment, like Feel free to include any additional details that might help me get this PR into a better state. You can manage your notification settings |
secrets.GITHUB_TOKEN is automatically inherited via secrets:inherit. Co-authored-by: openhands <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR adds
workflow_callsupport to the benchmarks build workflow as part of the solution for OpenHands/software-agent-sdk#1249.Purpose: Enable the software-agent-sdk repository to call this workflow directly instead of using dispatch + poll pattern, eliminating 80+ minutes of polling overhead.
Changes
workflow_call Trigger Added
Key Features
workflow_dispatchandpull_request_targettriggers preservedRelated PRs
Benefits
When called from software-agent-sdk:
Testing Status
✅ Workflow syntax validated
✅ Compatible with existing triggers
✅ Outputs properly defined
Part of Issue
Implements part of the solution for OpenHands/software-agent-sdk#1249