Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release process does not generate infered hierarchy #1124

Closed
1 task done
MGlauer opened this issue May 2, 2022 · 10 comments
Closed
1 task done

Release process does not generate infered hierarchy #1124

MGlauer opened this issue May 2, 2022 · 10 comments
Assignees
Labels
stale already discussed issues that haven't got worked on for a while

Comments

@MGlauer
Copy link
Contributor

MGlauer commented May 2, 2022

Description of the issue

The current release process merges all ontologies into a single ontology file, but does not include the logical closure of all axioms. This requires applications to infer parts of the hierarchy themselves, which is often beyond the scope of these projects and computationally expensive.

Ideas of solution

Extend the release script to include a call to the hermit reasoner that generates all inferences.

Workflow checklist

  • I am aware of the workflow for this repository
@MGlauer MGlauer added the To do Issues that haven't got discussed yet label May 2, 2022
@MGlauer MGlauer self-assigned this May 2, 2022
@l-emele l-emele added this to the oeo-release-1.10.0 milestone May 4, 2022
@l-emele
Copy link
Contributor

l-emele commented Dec 20, 2022

@MGlauer: Was there any progress on this in the last months?

@l-emele
Copy link
Contributor

l-emele commented Jan 18, 2023

@MGlauer : Any chance that we extend the release script before the next release which is due on February, 1st?

@areleu
Copy link
Contributor

areleu commented Feb 1, 2023

I think this can get funny because of #1424 .

I propose #1465 but I am not completely sure if its working as intended

@github-actions github-actions bot removed the To do Issues that haven't got discussed yet label Feb 1, 2023
@l-emele
Copy link
Contributor

l-emele commented Feb 1, 2023

I propose #1465 but I am not completely sure if its working as intended

If you are not sure if it is working, it should not be merged to dev, especially not directly before a release!

@areleu
Copy link
Contributor

areleu commented Feb 7, 2023

I think this can get funny because of #1424 .

I propose #1465 but I am not completely sure if its working as intended

With #1475 I think this problem will no longer be there.

@areleu
Copy link
Contributor

areleu commented Feb 8, 2023

Instead of replacing oeo-full I propose we provide a file called oeo-closed. This is the current implementation of #1465

@areleu
Copy link
Contributor

areleu commented Feb 14, 2023

@MGlauer The reasoner goes into a apparently infinite loop, is this related to the issue you found earlier at #1125 ?

Edit: Probably related to my last comment at #1430

@areleu
Copy link
Contributor

areleu commented Feb 14, 2023

After removing the problemating axiom from #1430 the ontology still does not close with robot :(

@areleu
Copy link
Contributor

areleu commented Feb 14, 2023

Issues with this kind of axioms: DisjointClass, PropertyAssertion I think the latter lies on some instances not being properly defined.

If we remove those from the types of axioms we no longer get issues.

@stale stale bot added the stale already discussed issues that haven't got worked on for a while label Mar 12, 2023
@stale stale bot removed stale already discussed issues that haven't got worked on for a while labels Mar 22, 2023
@stale stale bot added the stale already discussed issues that haven't got worked on for a while label Apr 6, 2023
@stale stale bot removed the stale already discussed issues that haven't got worked on for a while label May 17, 2023
@stale stale bot added the stale already discussed issues that haven't got worked on for a while label Jun 15, 2023
@stale stale bot removed the stale already discussed issues that haven't got worked on for a while label Aug 1, 2023
@stale stale bot added the stale already discussed issues that haven't got worked on for a while label Sep 16, 2023
@stap-m
Copy link
Contributor

stap-m commented Dec 4, 2023

Since #1465 is completed, I close this issue now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale already discussed issues that haven't got worked on for a while
Projects
Status: Done
Development

No branches or pull requests

6 participants