Add error page

Author: pablothedude

config/packages/framework.yaml

@@ -16,3 +16,4 @@ framework:
     #fragments: true
     php_errors:
         log: true
+

src/Infrastructure/Controller/SingleSignOnReturnController.php

@@ -60,9 +60,9 @@ public function __invoke(): Response
                 return $this->ssoAuthenticationReturnAction();
             }
         } catch (RuntimeException $e) {
-            return $this->render('default/unrecoverableError.html.twig', [
-                'message' => $e->getMessage(),
-            ], new Response('', Response::HTTP_NOT_ACCEPTABLE));
+            $this->logger->alert('Unable to handle return action: ' . $e->getMessage());
+
+            throw $e;
         }
 
         throw new UnrecoverableErrorException('Application state invalid');

templates/bundles/TwigBundle/Exception/error.html.twig

@@ -0,0 +1,11 @@
+{% set page_title = 'readid.error.title'|trans %}
+{% set intro = 'readid.error_message_intro'|trans ~ logs %}
+{% set title = 'readid.error.title'|trans %}
+
+{% extends 'base.html.twig' %}
+
+{% block page_title %}{% endblock %}
+
+{% block body %}
+    {% include('partial/error.html.twig') %}
+{% endblock %}

templates/bundles/TwigBundle/Exception/error404.html.twig

@@ -0,0 +1,11 @@
+{% set page_title = 'readid.page_not_found.title'|trans %}
+{% set intro = 'readid.page_not_found_intro'|trans ~ logs %}
+{% set title = 'readid.page_not_found.title'|trans %}
+
+{% extends 'base.html.twig' %}
+
+{% block page_title %}{% endblock %}
+
+{% block body %}
+    {% include('partial/error.html.twig') %}
+{% endblock %}

templates/default/unrecoverableError.html.twig

@@ -0,0 +1,15 @@
+<div class="d-flex flex-column-reverse flex-lg-row align-content-center">
+    <div class="p-2">
+        <h2>{{ title }}</h2>
+        {% if intro is not null %}
+            <p>
+                {{ intro }}
+            </p>
+        {% endif %}
+        {% if message is not null %}
+            <p>
+                {{ message }}
+            </p>
+        {% endif %}
+    </div>
+</div>

templates/partial/error.html.twig

@@ -1,3 +1,5 @@
-readid.unrecoverable_error: Unrecoverable error
-readid.unrecoverable_error_message_intro: Unrecoverable error
-readid.unrecoverable_error.title: Unrecoverable error
+readid.error.title: 'Oops, something went wrong'
+readid.error_message_intro: 'Sorry, something went wrong, please try again.'
+site_title: ReadID
+readid.page_not_found.title: 'Page not found'
+readid.page_not_found_intro: 'The requested page does not exists'

translations/messages.en.yaml

@@ -0,0 +1,5 @@
+readid.error.title: 'Sorry, er ging iets mis'
+readid.error_message_intro: 'Er is iets mis gegaan, probeer het opnieuw'
+site_title: ReadID
+readid.page_not_found.title: 'Page niet gevonden'
+readid.page_not_found_intro: 'De opgevraagde pagina bestaat niet'