From cec99f1fc391bbc272bc7d42f5ed26e7a0b41e8f Mon Sep 17 00:00:00 2001 From: SMIT PATEL <147633120+smit23patel@users.noreply.github.com> Date: Sun, 27 Oct 2024 21:33:39 +0530 Subject: [PATCH] Update generators.py 1. Use of get Method: In the from_dict method, I replaced direct indexing with the get method to provide a default value if the role type is not found. 2. Consistent Role Type Usage: Updated the return statement in from_dict to use the correct role_type instead of defaulting to RoleType.DEFAULT. --- camel/generators.py | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/camel/generators.py b/camel/generators.py index 47901a439..93cc59322 100644 --- a/camel/generators.py +++ b/camel/generators.py @@ -110,10 +110,10 @@ def from_dict( """ self.validate_meta_dict_keys(meta_dict) role_name, role_type = role_tuple - sys_prompt = self.sys_prompts[role_type] + sys_prompt = self.sys_prompts.get(role_type, self.sys_prompts[RoleType.DEFAULT]) # Updated to use get method sys_prompt = sys_prompt.format(**meta_dict) - return SystemMessage(role_name=role_name, role_type=RoleType.DEFAULT, + return SystemMessage(role_name=role_name, role_type=role_type, # Updated to use role_type meta_dict=meta_dict, content=sys_prompt) def from_dicts( @@ -265,3 +265,4 @@ def from_role_generator( self, role_generator: Generator[Tuple, None, None] ) -> Generator[str, None, None]: raise NotImplementedError +