Skip to content

Removing a mandatory or optional property in the input data : breaking change ? #599

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Kourtakis opened this issue Dec 19, 2023 · 2 comments
Labels
Breaking/Non-Breaking classification Issues related to Breaking/Non-Breaking changes classification question

Comments

@Kourtakis
Copy link

Removing a mandatory or optional property in the input data (request body) is NOT recognized as a breaking change in the tool.
Why not ?

@danilofuchs
Copy link

I believe this is not a breaking change. If you remove the need for a field, if old clients send that field, the server should just ignore it and work as usual.

@myoffe
Copy link

myoffe commented Mar 26, 2025

I disagree that it's not a breaking change.
In reality, it seems that one approach does not fit everyone, and it should be configurable.

I've wrote my opinion regarding the tool's behavior when optional fields are removed here: #198 (comment)

@DrSatyr DrSatyr added the Breaking/Non-Breaking classification Issues related to Breaking/Non-Breaking changes classification label Apr 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Breaking/Non-Breaking classification Issues related to Breaking/Non-Breaking changes classification question
Projects
None yet
Development

No branches or pull requests

4 participants