fix for issue 814 (#836)

* changed equal validation for changed example to properly validate arrays of primitive types

changed equal validation for changed example to properly validate arrays of primitive types

* removed unnecessary import from test class

* proposed new solution with deepEquals on Objects, fix also added to ChangedExamples.java, Fixed suggestion from copilot, grammatical error

* formatting fix

formatting fix

* moved test from ConsoleRenderTest to SchemaDiffTest class as suggested in review

* Moved test resource to proper location

Author: wexom

core/src/main/java/org/openapitools/openapidiff/core/model/ChangedExample.java

@@ -30,9 +30,10 @@ public void setRightExample(Object rightExample) {
 
   @Override
   public DiffResult isChanged() {
-    if (!Objects.equals(leftExample, rightExample)) {
+    if (!Objects.deepEquals(leftExample, rightExample)) {
       return DiffResult.METADATA;
     }
+
     return DiffResult.NO_CHANGES;
   }
 

core/src/main/java/org/openapitools/openapidiff/core/model/ChangedExamples.java

@@ -30,7 +30,7 @@ public void setRightExamples(Object rightExamples) {
 
   @Override
   public DiffResult isChanged() {
-    if (!Objects.equals(leftExamples, rightExamples)) {
+    if (!Objects.deepEquals(leftExamples, rightExamples)) {
       return DiffResult.METADATA;
     }
     return DiffResult.NO_CHANGES;

core/src/main/java/org/openapitools/openapidiff/core/output/AsciidocRender.java

@@ -34,7 +34,7 @@ public void render(ChangedOpenApi diff, OutputStreamWriter outputStreamWriter) {
               diff.getNewSpecOpenApi().getInfo().getVersion()));
       safelyAppend(outputStreamWriter, System.lineSeparator());
       safelyAppend(outputStreamWriter, System.lineSeparator());
-      safelyAppend(outputStreamWriter, "NOTE: No differences. Specifications are equivalents");
+      safelyAppend(outputStreamWriter, "NOTE: No differences. Specifications are equivalent");
     } else {
       safelyAppend(
           outputStreamWriter,

core/src/main/java/org/openapitools/openapidiff/core/output/ConsoleRender.java

@@ -27,7 +27,7 @@ public class ConsoleRender implements Render {
   public void render(ChangedOpenApi diff, OutputStreamWriter outputStreamWriter) {
     this.diff = diff;
     if (diff.isUnchanged()) {
-      safelyAppend(outputStreamWriter, "No differences. Specifications are equivalents");
+      safelyAppend(outputStreamWriter, "No differences. Specifications are equivalent");
     } else {
       safelyAppend(outputStreamWriter, bigTitle("Api Change Log"));
       safelyAppend(

core/src/test/java/org/openapitools/openapidiff/core/SchemaDiffTest.java

@@ -438,4 +438,21 @@ public void testAllOfDiff() {
     assertThat(changedSchema.getRequired().getMissing()).containsExactly("fieldA");
     assertThat(changedSchema.getRequired().getIncreased()).isEmpty();
   }
+
+  @Test
+  void renderShowsNoDifferencesWhenCSVMediaTypeResponseExampleIsByteArray() {
+    ChangedOpenApi changedOpenApi =
+        OpenApiCompare.fromLocations(
+            "schemaDiff/issue-828-binary-example-for-csv-media-type.yaml",
+            "schemaDiff/issue-828-binary-example-for-csv-media-type.yaml");
+
+    assertThat(changedOpenApi).isNotNull();
+
+    assertThat(changedOpenApi.isUnchanged()).isTrue();
+    assertThat(changedOpenApi.isDifferent()).isFalse();
+    assertThat(changedOpenApi.isChanged()).isEqualTo(DiffResult.NO_CHANGES);
+    assertThat(changedOpenApi.isIncompatible()).isFalse();
+    assertThat(changedOpenApi.isCompatible()).isTrue();
+    assertThat(changedOpenApi.isCoreChanged()).isEqualTo(DiffResult.NO_CHANGES);
+  }
 }

core/src/test/resources/schemaDiff/issue-828-binary-example-for-csv-media-type.yaml

@@ -0,0 +1,26 @@
+openapi: 3.0.1
+info:
+  title: My API
+  version: 1.0.0
+paths:
+  /api/v1/csv:
+    get:
+      operationId: someCsvEndpoint
+      responses:
+        "200":
+          content:
+            text/csv:
+              schema:
+                type: string
+                format: binary
+                example: Example
+          description: Successful operation
+      security:
+        - Bearer: []
+      summary: Download a CSV or something
+components:
+  securitySchemes:
+    Bearer:
+      bearerFormat: JWT
+      scheme: bearer
+      type: http