Revert "support signed links to auxiliary files in batch job result STAC items"

This reverts commit 1109ec4.

This added top-level (Collection) links to item-level links implicitly so not right conceptually.
Support dedicated derived_from document only for "STAC 1.1 items" (implemented in #411).

Open-EO/openeo-geopyspark-driver#1278

Author: bossie

CHANGELOG.md

@@ -26,7 +26,6 @@ and start a new "In Progress" section above it.
 - `DiskWorkspace`: support unified asset keys ([Open-EO/openeo-geopyspark-driver#1111](https://github.com/Open-EO/openeo-geopyspark-driver/issues/1111))
 - Support persisting results metadata URI in job registry ([Open-EO/openeo-geopyspark-driver#1255](https://github.com/Open-EO/openeo-geopyspark-driver/issues/1255))
 - More fine-grained `convert_node` cache control ([Open-EO/openeo-geopyspark-driver#1331](https://github.com/Open-EO/openeo-geopyspark-driver/issues/1331)/[#422](https://github.com/Open-EO/openeo-python-driver/pull/422))
-- Support signed links to auxiliary files in batch job result STAC items ([Open-EO/openeo-geopyspark-driver#1278](https://github.com/Open-EO/openeo-geopyspark-driver/issues/1278))
 
 
 ## 0.134.0

openeo_driver/_version.py

@@ -1 +1 @@
-__version__ = "0.135.0a8"
+__version__ = "0.135.0a7"

openeo_driver/views.py

@@ -1382,13 +1382,6 @@ def _get_job_result_item(job_id, item_id, user_id):
 
         job_info = backend_implementation.batch_jobs.get_job_info(job_id, user_id)
 
-        exposable_links = [link for link in (job_info.links or []) if link.get("_expose_internal", False)]
-        for link in exposable_links:
-            link.pop("_expose_internal")
-            link["href"] = backend_implementation.config.asset_url.build_url(  # TODO: not an asset
-                    asset_metadata={}, asset_name=pathlib.Path(link["href"]).name, job_id=job_id, user_id=user_id  # TODO: assumes href is an absolute file path; prepare for S3 URI and put it in asset_metadata's href?
-                )
-
         geometry = asset_metadata.get("geometry", job_info.geometry)
         bbox = asset_metadata.get("bbox", job_info.bbox)
 
@@ -1445,8 +1438,7 @@ def _get_job_result_item(job_id, item_id, user_id):
                     "href": url_for(".list_job_results", job_id=job_id, _external=True),  # SHOULD be absolute
                     "type": "application/json",
                 },
-            ]
-            + exposable_links,
+            ],
             "assets": {asset_filename: _asset_object(job_id, user_id, asset_filename, asset_metadata, job_info)},
             "collection": job_id,
         }

tests/test_views.py

@@ -1336,14 +1336,6 @@ def _fresh_job_registry(next_job_id="job-1234", output_root: Optional[Path] = No
                     end_datetime=datetime(1981, 4, 24, 3, 0, 0),
                     instruments=["MSI"],
                     epsg=4326,
-                    links=[
-                        {
-                            "rel": "custom",
-                            "href": "53c71345-09b4-46b4-b6b0-03fd6fe1f199_input_items.json",
-                            "type": "application/json",
-                            "_expose_internal": True,
-                        }
-                    ],
                     plan="some_plan",
                     costs=1.23,
                     budget=4.56,
@@ -3120,12 +3112,6 @@ def test_get_job_result_item(self, flask_app, api110, backend_config_overrides):
                     "href": "http://oeo.net/openeo/1.1.0/jobs/53c71345-09b4-46b4-b6b0-03fd6fe1f199/results",
                     "type": "application/json",
                 },
-                {
-                    "rel": "custom",
-                    # TODO: what does the URL look like? Currently /aux instead of /assets; should /items be in there?
-                    "href": "http://oeo.net/openeo/1.1.0/jobs/53c71345-09b4-46b4-b6b0-03fd6fe1f199/results/aux/TXIuVGVzdA==/e8ad3022a08bbc5c123597c1f948f6d4/53c71345-09b4-46b4-b6b0-03fd6fe1f199_input_items.json?expires=2234",
-                    "type": "application/json",
-                },
             ],
             "assets": {
                 "output.tiff": {